[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v5 09/44] x86/boot: introduce boot module types


  • To: "Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Jason Andryuk <jason.andryuk@xxxxxxx>
  • Date: Mon, 7 Oct 2024 15:50:53 -0400
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=apertussolutions.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9PNy/YK5F8zUiWjHfpze0wKfCrrd86+vfXfJLFlEJ78=; b=eKhEjxgkLhdjWe3t86SL4oJbY7ivsILY7ktr+KQxJr5QhzzP2ULc+gQRGhnlCB5nLAibtp/zMTZBoynaC8NU4Jd3B/HaJsQl1noAmrYB260SQZ0GCcyzqCn6enDHlUB8ZwTMmd1VDTk6fTnpPCs1U5PWVxzdCUqcaQRcNzwEN+pwMboYJoKKSZRoYKInonzxhjsbqACd93u59QEHHJxIxK4eHOwBshDGrYe5h6Kr/M8SCvPWO6npILDInwJemcCQDTNStMjn1OWQtaR1vRF3xByYBWI9kWzIexkxsBKeJdtvuiX5TpXLiQ/lkCGPvFYQl3BxulkPvYESVgxrla0QxQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=rswqdLJY1aksJvD/2Vsgo8C0GmZ8Z8HEcVXobe/RhT1pJkF7D7i6+zfa7ZyO3UNHiDBVnmfRmQZtyFbOsrOmkPJluI8hdnIDa1RFM6t+voMVMZbwjagLGQDtBiTsKz/yA7TEozIiVPnjl+nL1N9/LzId0/DeYOrJZF2Tujfjibsvj1FccXj3Rnp6pvUISeVKwa5obWo2k4YfdMF3zXrAGeB27rIOtx/3li1c6h7hZkOglv1koHupdOlKWNtt+LVZeFro2OYbpMvv+iH73vqL2TbTYQo5LRKWiaMJzPAoaEAeFVeGLGey7uUFQQQilxeGisVh+e3XZ4E4a+PYqsIbTg==
  • Cc: <christopher.w.clark@xxxxxxxxx>, <stefano.stabellini@xxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Delivery-date: Mon, 07 Oct 2024 19:51:10 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 2024-10-06 17:49, Daniel P. Smith wrote:
This commit introduces module types of xen, kernel, and ramdisk to allow boot
module detect code to tag the purpose of a boot module. This reduces the need
for hard coded order assumptions and global variables to be used by consumers
of boot modules, such as domain construction.

Signed-off-by: Daniel P. Smith <dpsmith@xxxxxxxxxxxxxxxxxxxx>
---

@@ -2058,6 +2063,7 @@ void asmlinkage __init noreturn __start_xen(unsigned long 
mbi_p)
             cpu_has_nx ? "" : "not ");
initrdidx = find_first_bit(module_map, bi->nr_modules);
+    bi->mods[initrdidx].type = BOOTMOD_RAMDISK;

This is incorrect if an initrd isn't present.

      if ( bitmap_weight(module_map, bi->nr_modules) > 1 )
          printk(XENLOG_WARNING
                 "Multiple initrd candidates, picking module #%u\n",



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.