Re: [PATCH v1 4/5] xen/arm: Enable early printk for S32CC via LINFlexD UART

[Julien Grall <julien@xxxxxxx>]

Hi,

On 10/09/2024 15:34, Andrei Cherechesu (OSS) wrote:
> From: Andrei Cherechesu <andrei.cherechesu@xxxxxxx>
>
> Enabled the support for debug through early printk on S32CC
NIT: We tend to avoid using past tense when describing the change. So 
s/Enabled/Enable/. However...
> platforms via the NXP LINFlexD UART driver.
>
> Signed-off-by: Andrei Cherechesu <andrei.cherechesu@xxxxxxx>
> ---
>   xen/arch/arm/Kconfig.debug | 4 ++++
>   1 file changed, 4 insertions(+)
>
> diff --git a/xen/arch/arm/Kconfig.debug b/xen/arch/arm/Kconfig.debug
> index a309f67f90..9725f4193c 100644
> --- a/xen/arch/arm/Kconfig.debug
> +++ b/xen/arch/arm/Kconfig.debug
> @@ -168,6 +168,9 @@ choice
>         config EARLY_PRINTK_RCAR3
>                 bool "Early printk with SCIF2 on Renesas R-Car Gen3 processors"
>                 select EARLY_UART_SCIF
> +       config EARLY_PRINTK_S32CC
> +               bool "Early printk with NXP LINFlexD UART on NXP S32CC 
> processors"
> +               select EARLY_UART_LINFLEX
... we stopped adding platform specific early printk a while ago because 
this is not scalable.
Instead, we prefer to write a page in [1] which will provide all the 
information how to setup and debug Xen on a SoC (could be one per family).
Cheers,

[1] https://wiki.xenproject.org/wiki/Xen_ARM_with_Virtualization_Extensions

--
Julien Grall