Re: [PATCH] xen/arm64: entry: Actually skip do_trap_*() when an SError is triggered

[Julien Grall <julien@xxxxxxx>]

On 06/08/2024 14:26, Michal Orzel wrote:
> Hi Julien,
>
> On 06/08/2024 14:48, Julien Grall wrote:
> > From: Julien Grall <jgrall@xxxxxxxxxx>
> >
> > For SErrors, we support two configurations:
> >    * Every SErrors will result to a panic in Xen
> >    * We will forward SErrors triggered by a VM back to itself
> >
> > For the latter case, we want to skip the call to do_trap_*() because the PC
> > was already adjusted.
> >
> > However, the alternative used to decide between the two configurations
> > is inverted. This would result to the VM corrupting itself if:
> >    * x19 is non-zero in the panic case
> >    * advance PC too much in the second case
> >
> > Solve the issue by switch from alternative_if to alternative_if_not.
> >
> > Fixes: a458d3bd0d25 ("xen/arm: entry: Ensure the guest state is synced when 
> > receiving a vSError")
> > Signed-off-by: Julien Grall <jgrall@xxxxxxxxxx>
> Acked-by: Michal Orzel <michal.orzel@xxxxxxx>
>
> > ----
> 3 instead of 4 dashes
I will fixed it.

The patchqueue tool I am using will strip anything after "---". So I am 
using ---- to version changelog... I tend to forget that I need to 
manually call sed -i 's/^----/---/' *.patch before sending every patch.
Cheers,

--
Julien Grall