[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] xen/arm64: entry: Actually skip do_trap_*() when an SError is triggered
- To: Julien Grall <julien@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Michal Orzel <michal.orzel@xxxxxxx>
- Date: Tue, 6 Aug 2024 15:26:49 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=xen.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3qAgu7bbX8Y4bq2KxCRNtu8hDQUJng1HwUV9zC6GnUo=; b=Qyu6cKyONpUJPeUPOkXkeWUgM1FJIWlwIHZ4KVeE2fVb0CrpwCJuXgeMNPai15wR8/JkBwXOHrHz0mKgSVxCsnFGdTxdBKTtGQtaPJHC5dbSS3X2N99O3XveqyYFX56RyGmg1gxwEjJk8eubZ4Ajfn6bzFFe8EeQRjDpmbi70ybmXLbNcElSpYnhIPraawOq7VwLtN39pOn3eL3U/eL6+KXeINrm0ArygCtQpSAOZUtNnP0TrzvlztbHTggJ5ZT8IldaLKfukP9MiFYHXK7vxppzVJuan/NaMljl1k79nBdO9M1Oy5z60q1e3gYbppg/n0kFW3B4b4tFH09r4Am5nA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=PiXmb0VTMK6NQZVNvx779RzU1HFc4tkVy8GHbRaAWfK3cGjq35PFoCov1323lGyWUEgoQfudoGp/BZoiUt2RYCHrq0C0hPpXU99B2JXeppUjUe9ePDKa/j6GNHyIC7kLvgEzLtvwWJ2yHuLdBtZByxApHmWaz2T+uPQSosuT4ZuL19JpZ79e4nS/l4/PZ+uyOVqXqiFU7WCV9E6AM4jIm22+g+TsxULAVsmPGCxz6S+42RVEbZ56+T9Qr7mw2w4SLjQLfiV8VunogYqXQj5hEQTJH3NmfFIssyZat2TDTP7EjseJVCjy44b1UyrqmxUOJUpIgNRkxrOiei/ZNqJ5BA==
- Cc: Julien Grall <jgrall@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Tue, 06 Aug 2024 13:27:13 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
Hi Julien,
On 06/08/2024 14:48, Julien Grall wrote:
>
>
> From: Julien Grall <jgrall@xxxxxxxxxx>
>
> For SErrors, we support two configurations:
> * Every SErrors will result to a panic in Xen
> * We will forward SErrors triggered by a VM back to itself
>
> For the latter case, we want to skip the call to do_trap_*() because the PC
> was already adjusted.
>
> However, the alternative used to decide between the two configurations
> is inverted. This would result to the VM corrupting itself if:
> * x19 is non-zero in the panic case
> * advance PC too much in the second case
>
> Solve the issue by switch from alternative_if to alternative_if_not.
>
> Fixes: a458d3bd0d25 ("xen/arm: entry: Ensure the guest state is synced when
> receiving a vSError")
> Signed-off-by: Julien Grall <jgrall@xxxxxxxxxx>
Acked-by: Michal Orzel <michal.orzel@xxxxxxx>
>
> ----
3 instead of 4 dashes
~Michal
|
