Re: [PATCH for-4.19] xen/arm: static-shmem: fix "gbase/pbase used uninitialized" build failure

[Michal Orzel <michal.orzel@xxxxxxx>]

Hi Julein,

On 19/06/2024 13:37, Julien Grall wrote:
> 
> 
> Hi,
> 
> On 19/06/2024 12:19, Oleksii K. wrote:
>> Hi,
>> On Wed, 2024-06-19 at 09:02 +0000, Bertrand Marquis wrote:
>>> Hi,
>>>
>>> Adding Oleksii for Release ack.
>>>
>>> Cheers
>>> Bertrand
>>>
>>>> On 19 Jun 2024, at 08:46, Michal Orzel <michal.orzel@xxxxxxx>
>>>> wrote:
>>>>
>>>> Building Xen with CONFIG_STATIC_SHM=y results in a build failure:
>>>>
>>>> arch/arm/static-shmem.c: In function 'process_shm':
>>>> arch/arm/static-shmem.c:327:41: error: 'gbase' may be used
>>>> uninitialized [-Werror=maybe-uninitialized]
>>>>   327 |         if ( is_domain_direct_mapped(d) && (pbase != gbase)
>>>> )
>>>> arch/arm/static-shmem.c:305:17: note: 'gbase' was declared here
>>>>   305 |         paddr_t gbase, pbase, psize;
>>>>
>>>> This is because the commit cb1ddafdc573 adds a check referencing
>>>> gbase/pbase variables which were not yet assigned a value. Fix it.
>>>>
>>>> Fixes: cb1ddafdc573 ("xen/arm/static-shmem: Static-shmem should be
>>>> direct-mapped for direct-mapped domains")
>>>> Signed-off-by: Michal Orzel <michal.orzel@xxxxxxx>
>> Release-Acked-by: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
> 
> I have committed to unblock the CI. But I have some questions on the
> approach. I will ask them separately.
The CI failures as seen in:
https://gitlab.com/xen-project/xen/-/pipelines/1338067978
are due to 2 issues. This patch solves the first one. The other is related to 
Henry's xenstore
series that without a corresponding Linux patch, that has been merged into 
mainline, causes a regression.
And thus all the dom0less PV tests fail. We will need to revert the xenstore 
patches for now.

~Michal