Re: [PATCH for-4.19] xen/arm: static-shmem: fix "gbase/pbase used uninitialized" build failure

[Julien Grall <julien@xxxxxxx>]

Hi,

On 19/06/2024 12:19, Oleksii K. wrote:
> Hi,
> On Wed, 2024-06-19 at 09:02 +0000, Bertrand Marquis wrote:
> > Hi,
> >
> > Adding Oleksii for Release ack.
> >
> > Cheers
> > Bertrand
> >
> > > On 19 Jun 2024, at 08:46, Michal Orzel <michal.orzel@xxxxxxx>
> > > wrote:
> > >
> > > Building Xen with CONFIG_STATIC_SHM=y results in a build failure:
> > >
> > > arch/arm/static-shmem.c: In function 'process_shm':
> > > arch/arm/static-shmem.c:327:41: error: 'gbase' may be used
> > > uninitialized [-Werror=maybe-uninitialized]
> > >   327 |         if ( is_domain_direct_mapped(d) && (pbase != gbase)
> > > )
> > > arch/arm/static-shmem.c:305:17: note: 'gbase' was declared here
> > >   305 |         paddr_t gbase, pbase, psize;
> > >
> > > This is because the commit cb1ddafdc573 adds a check referencing
> > > gbase/pbase variables which were not yet assigned a value. Fix it.
> > >
> > > Fixes: cb1ddafdc573 ("xen/arm/static-shmem: Static-shmem should be
> > > direct-mapped for direct-mapped domains")
> > > Signed-off-by: Michal Orzel <michal.orzel@xxxxxxx>
> Release-Acked-by: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
I have committed to unblock the CI. But I have some questions on the 
approach. I will ask them separately.
Cheers,

--
Julien Grall