[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 06/14] sd: add a sd_disable_discard helper


  • To: Christoph Hellwig <hch@xxxxxx>
  • From: "Martin K. Petersen" <martin.petersen@xxxxxxxxxx>
  • Date: Thu, 13 Jun 2024 21:41:58 -0400
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7pXJbR58xIZBK1VUuESN0sDYFJkgoy9TJWPs3H49R9g=; b=F/1nIkTvYO2MSvEZm9MaQ/ovvK88MVlaUkhXyT0O7N/b1+5VvcKsSw2TO2vnVmZYJIyvs8asFo4p1WdL8AHa4WqMSZIazCmoQRqIxe5w2xrqeKz6iP7Wvt+yQaojOZpD3RLoqzvHFj33J98SGwvMdjGxiWbGHf7wHzSoYzIJJxcz13FsYK06GOnAyT/zXgxPaBRFZXXbvzM05WBB3cw2SMrF3KRbamLGloR8/8WiymvrwN6GEMGuBQIfXoMH3BOcFJ9OW0JZjGhUUC9stsMsAj43wIfNsb/qxG42pgFpqVxW8nHFZq7U33aOA+c6QUOUVgHf0jvi+jhRHUi7iICCbQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=P9j5WF2WHZufuGu5Iq46y/3d4OhxO9t/yDBQarbgqdXpbMP1nuZ9wn8nYIqGsE7mkiCc0t/wEFUupR4WSWXDs6WSaqqnHy4h1Zn667yduxBnkor2oSD3w64lXsM6i3MWNDF5ek7YKQZD3zEbHwDHyN18novHGHI4LOAVPysC3f2BfwadCYBI8H7TxS9fCEXpzGIdQ2Ahjriosao080bpuKWhekrz3pjaUCAW+ZJa4wXlt/adDIblezUvu+ui9of1acomQ4vVH39RyifNJbz4jArF6je+GMf3nFOT22Br2g2dmfTXsoXFfuznqzZHFqpMpchh4vdhyiN5JsXCD7xQug==
  • Cc: Jens Axboe <axboe@xxxxxxxxx>, "Martin K. Petersen" <martin.petersen@xxxxxxxxxx>, Richard Weinberger <richard@xxxxxx>, Anton Ivanov <anton.ivanov@xxxxxxxxxxxxxxxxxx>, Johannes Berg <johannes@xxxxxxxxxxxxxxxx>, Josef Bacik <josef@xxxxxxxxxxxxxx>, Ilya Dryomov <idryomov@xxxxxxxxx>, Dongsheng Yang <dongsheng.yang@xxxxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, linux-um@xxxxxxxxxxxxxxxxxxx, linux-block@xxxxxxxxxxxxxxx, nbd@xxxxxxxxxxxxxxxx, ceph-devel@xxxxxxxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx, linux-scsi@xxxxxxxxxxxxxxx, Bart Van Assche <bvanassche@xxxxxxx>, Damien Le Moal <dlemoal@xxxxxxxxxx>
  • Delivery-date: Fri, 14 Jun 2024 01:42:23 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

Christoph,

> Add helper to disable discard when it is not supported and use it
> instead of sd_config_discard in the I/O completion handler.  This avoids
> touching more fields than required in the I/O completion handler and
> prepares for converting sd to use the atomic queue limits API.

Reviewed-by: Martin K. Petersen <martin.petersen@xxxxxxxxxx>

-- 
Martin K. Petersen      Oracle Linux Engineering



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.