[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 05/14] sd: simplify the ZBC case in provisioning_mode_store


  • To: Christoph Hellwig <hch@xxxxxx>
  • From: "Martin K. Petersen" <martin.petersen@xxxxxxxxxx>
  • Date: Thu, 13 Jun 2024 21:41:28 -0400
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YsTri5LDgJOZ7rOHk62Dvpk2ux3OuDk+pxi14XzdcgM=; b=YSlQJmjetA1m7vYDyIL5Sc6dqarC2HenhoHgmFUrEXKAVS6tiSSPGMn1KH2VeEJ/AcKH/xAKhxthdakWBmd7N4cnao8MU9Np8cDkHfNV4iDbx9LK5XjGXB44pGSDHRhZdiovX0ziHpVekZ7/odD3h+AKw/u8VtjptY4E8yXt9jmlqaGEKID2/Q0XeT+ZTi8+0L7hcDo3XUiTlMZeswwMW8Hr+kAXNy06j3aVGpZ6lMe0EYi18owONAGz2m7BJYbN2J09VDrmxeU9YNI8adzWHkPeMD1jlUebo8/6mueqQjUhadcMCG7nsr791br3vQJRmerrsfRJX9imdVkeJGk4hA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gZP3sdNOEkKZHdvO4AmZZCc2/Z64i6VEzdJL8DfNnfJNc++djEHvtVmQIWVggqkxkb2S0r03GgfU4YTvPq6ItwCVnBYgVPo75M8LWsTNQhlMKhKJetDek5o5pAQnjtRpGDFOlLlK/L4VPrB0jhp+E9deARVoQkwCTjylwr6IebMFtZauzTlLbRi0IfUjCILY+yt5RNayqb0MO21QsX4Tl3k6YtBCs+G5xBL12/FRoj60rg8UsFff23hmK3awMqdxnVn//7ttxVTz2Ee/9166XzLcxiAZyEA+wYFsfyTWGT993Pr3j081jkONsuoPa5Wri4gUdJ9Nb3yfM40tX5qk8g==
  • Cc: Jens Axboe <axboe@xxxxxxxxx>, "Martin K. Petersen" <martin.petersen@xxxxxxxxxx>, Richard Weinberger <richard@xxxxxx>, Anton Ivanov <anton.ivanov@xxxxxxxxxxxxxxxxxx>, Johannes Berg <johannes@xxxxxxxxxxxxxxxx>, Josef Bacik <josef@xxxxxxxxxxxxxx>, Ilya Dryomov <idryomov@xxxxxxxxx>, Dongsheng Yang <dongsheng.yang@xxxxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, linux-um@xxxxxxxxxxxxxxxxxxx, linux-block@xxxxxxxxxxxxxxx, nbd@xxxxxxxxxxxxxxxx, ceph-devel@xxxxxxxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx, linux-scsi@xxxxxxxxxxxxxxx, Bart Van Assche <bvanassche@xxxxxxx>, Damien Le Moal <dlemoal@xxxxxxxxxx>
  • Delivery-date: Fri, 14 Jun 2024 01:42:01 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

Christoph,

> Don't reset the discard settings to no-op over and over when a user
> writes to the provisioning attribute as that is already the default
> mode for ZBC devices.  In hindsight we should have made writing to
> the attribute fail for ZBC devices, but the code has probably been
> around for far too long to change this now.

Reviewed-by: Martin K. Petersen <martin.petersen@xxxxxxxxxx>

-- 
Martin K. Petersen      Oracle Linux Engineering



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.