[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH v3 03/16] x86/p2m: guard altp2m routines
- To: Stefano Stabellini <sstabellini@xxxxxxxxxx>
- From: Sergiy Kibrik <sergiy_kibrik@xxxxxxxx>
- Date: Mon, 10 Jun 2024 13:33:47 +0300
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cd1moHxhc1xm770fqgTpoNlWwNdQuDUv7YAsKOXFusI=; b=G0Q4zyTM42oYWrw2l8Z6fsMpB8mGU6cw7A0Q3Fhc/YrNUmOq4D1ETpC868cC+2o7pt+DHcx+eQuub8vDJGS1P3MyyGBbCjJwFcQMQzbmCiFUsSz3VTD7iSwMt6GLm2TCyfKXjEdHZhGEwM7eHnMdDbp23l3OSPpCcD7arjgZM4aPoMJm5kdGUM7S6qywhq1Ks4KFYI7myHohXcp0D9MmRlkxZkATDtqf/z3koPJ5SWzHbuiOrxB/1p9nC/w3ZKOf6skeDqMH8pUE/rjmYkv39BQZmo5HWlCFKQ62pzRLc5AITLdkuTwC39B5+gztYiwCT4qFvA/Oif4ZPweeCt5L8A==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EsFpwTm8cxnCnqtJNL0KbuAlWwAwdEw1uF9VgR3D1wmhzQat9EvGdt1zccDqLMr/HKsrBO2mD/g5YuyTPbCNZuFKUQgKfqxycTpzaWv7Vxo5MHejD0VdtNYmkSmMU6+i8HQ+1kCsT0mimTf0Gk0p+TTbQ0gwYNNOwQtRujn5rxpP0Voa+thepv72ni7t02jCJR08snZmfsDWarVpAa0Dak232J4wScwBY9hp8T/L29a+EU2DznAIxq6GBfBigq64KVTlWz6WNHuHiAHxPuiX1sxh6mDU1m1J8i7DTYHfmDr95CMtsOJflb4ZSwpI4pJTq3l1WR4GCCE9Xq/w05ng0w==
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Xenia Ragiadakou <xenia.ragiadakou@xxxxxxx>, Tamas K Lengyel <tamas@xxxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx, Jan Beulich <jbeulich@xxxxxxxx>
- Delivery-date: Mon, 10 Jun 2024 10:34:09 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
hi Stefano,
07.06.24 10:32, Jan Beulich:
On 03.06.2024 13:11, Sergiy Kibrik wrote:
Initialize and bring down altp2m only when it is supported by the platform,
e.g. VMX. Also guard p2m_altp2m_propagate_change().
The puspose of that is the possiblity to disable altp2m support and exclude its
code from the build completely, when it's not supported by the target platform.
Signed-off-by: Sergiy Kibrik <Sergiy_Kibrik@xxxxxxxx>
Reviewed-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>
Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
I question though whether Stefano's R-b was valid to retain with ...
---
changes in v3:
- put hvm_altp2m_supported() first
- rewrite changes to p2m_init() with less code
... this.
could you please take a look at this patch once more, after it's been
through these modifications? Thank you!
-Sergiy
|
