Re: [XEN PATCH v3 03/16] x86/p2m: guard altp2m routines

[Jan Beulich <jbeulich@xxxxxxxx>]

On 03.06.2024 13:11, Sergiy Kibrik wrote:
> Initialize and bring down altp2m only when it is supported by the platform,
> e.g. VMX. Also guard p2m_altp2m_propagate_change().
> The puspose of that is the possiblity to disable altp2m support and exclude 
> its
> code from the build completely, when it's not supported by the target 
> platform.
> 
> Signed-off-by: Sergiy Kibrik <Sergiy_Kibrik@xxxxxxxx>
> Reviewed-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>

Acked-by: Jan Beulich <jbeulich@xxxxxxxx>

I question though whether Stefano's R-b was valid to retain with ...

> ---
> changes in v3:
>  - put hvm_altp2m_supported() first
>  - rewrite changes to p2m_init() with less code

... this.

Jan