[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 14/15] add a domU script to fetch overlays and applying them to linux
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Henry Wang <xin.wang2@xxxxxxx>
- Date: Thu, 25 Apr 2024 08:54:00 +0800
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=suse.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MmZ4ClUD+R6nCod+fldRPcvrqL2Vg2CqlbBWdWc4NfU=; b=go0CIRiPw1SJ+bF5ZjiJ2JSy+D3H/QgeXAIx9Hd/HjPhlOucsD67qHZxXlX7AQ86yXAWXPn1VZTiB8iQ51bFcAc6WH2vIDnkIXAKCO52CIZKA2gektnm5KmgWC7nfbR53aiOuEYAMFgQ2/B+MTRUNBzexxhTAB5B7I7WsqVsYH9xihhAutFTa1Kguzenpjl8qINRNSDu/Mkul+KbzDQttCZUH+escHF17Bs3lhRydb8ddaOqxtN87Q6JP80z6/lOffyO6b9W3ezcpqYkpRzhV40nM0X5s8B5gmoOPoVwIRLA5StCDdWU2FLcqp4EvUC1LXFz3J5e+zyIL6BVArvQAg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CFEYnwpzNSG3OUtIlF7Vax3ObPwI6Z7c140y+hM4FplrOIHjz7HNzKAE8svfB5zz4lKJtRUC15g2QRQYktw673mqjfm/TatlZOMh5joPFu/fa1txyctZ25Me7jwRWabtn2A0vKiN+pNNlKMt0h7VDJI5MO5i5jSQ3ERpoaODfBD70Ss9FDD4B0UBiteCuRjipB/ix3JlxIW7Q8a3Rkucgiqw4R0hohIVYLp1mkNUC8DJQat3IMtn00z7XzVOsAph9+pnsSJJVPQ7LVrybMGWoheRwFv1oDUnFKFx/Fnw0DGwNVXB1qd8ZaY0gmcBZi39EpvTdtOTUnWLhtn8VCYkLw==
- Cc: Anthony PERARD <anthony.perard@xxxxxxxxxx>, Stefano Stabellini <stefano.stabellini@xxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Thu, 25 Apr 2024 00:54:13 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
Hi Jan,
On 4/24/2024 2:16 PM, Jan Beulich wrote:
On 24.04.2024 05:34, Henry Wang wrote:
From: Vikram Garhwal <fnu.vikram@xxxxxxxxxx>
Introduce a shell script that runs in the background and calls
get_overlay to retrive overlays and add them (or remove them) to Linux
device tree (running as a domU).
Signed-off-by: Vikram Garhwal <fnu.vikram@xxxxxxxxxx>
Signed-off-by: Stefano Stabellini <stefano.stabellini@xxxxxxxxxx>
Signed-off-by: Henry Wang <xin.wang2@xxxxxxx>
---
tools/helpers/Makefile | 2 +-
tools/helpers/get_overlay.sh | 81 ++++++++++++++++++++++++++++++++++++
2 files changed, 82 insertions(+), 1 deletion(-)
create mode 100755 tools/helpers/get_overlay.sh
Besides the same naming issue as in the earlier patch, the script also
looks very Linux-ish. Yet ...
I will fix the naming issue in v2. Would you mind elaborating a bit more
about the "Linux-ish" concern? I guess this is because the original use
case is on Linux, should I do anything about this?
--- a/tools/helpers/Makefile
+++ b/tools/helpers/Makefile
@@ -58,7 +58,6 @@ init-dom0less: $(INIT_DOM0LESS_OBJS)
get_overlay: $(SHARE_OVERLAY_OBJS)
$(CC) $(LDFLAGS) -o $@ $< $(LDLIBS_libxenvchan) $(LDLIBS_libxenstore)
$(LDLIBS_libxenctrl) $(LDLIBS_libxengnttab) $(APPEND_LDFLAGS)
-
.PHONY: install
install: all
$(INSTALL_DIR) $(DESTDIR)$(LIBEXEC_BIN)
@@ -67,6 +66,7 @@ install: all
.PHONY: uninstall
uninstall:
for i in $(TARGETS); do rm -f $(DESTDIR)$(LIBEXEC_BIN)/$$i; done
+ $(RM) $(DESTDIR)$(LIBEXEC_BIN)/get_overlay.sh
.PHONY: clean
clean:
... you touching only the uninstall target, it's not even clear to me
how (and under what conditions) the script is going to make it into
$(DESTDIR)$(LIBEXEC_BIN)/. Did you mean to add to $(TARGETS), perhaps,
alongside the earlier added get-overlay binary?
You are right, I think the get-overlay binary and this script should be
installed if DTB overlay is supported. Checking the code, I found
LIBXL_HAVE_DT_OVERLAY which can indicate if we have this feature
supported in libxl. Do you think it is a good idea to use it to install
these two files in Makefile? Thanks.
Kind regards,
Henry
Jan
|
