Re: [PATCH 06/15] rangeset: Move struct range and struct rangeset to headerfile

[Henry Wang <xin.wang2@xxxxxxx>]

Hi Jan,

On 4/24/2024 2:22 PM, Jan Beulich wrote:
> On 24.04.2024 05:34, Henry Wang wrote:
> > From: Vikram Garhwal <vikram.garhwal@xxxxxxx>
> >
> > Move struct range, rangeset and removed static from first_range and 
> > next_range().
> NAK, for going against what we do elsewhere (limiting exposure of internals).
> At least as long as the justification isn't any better than ...
>
> > IRQs and IOMEMs for nodes are stored as rangeset in the dynamic node addition
> > part. While removing the nodes we need to access every IRQ and IOMEM ranges to
> > unmap IRQ and IOMEM from the domain.
> ... this. You're aware of rangeset_report_ranges() and 
> rangeset_consume_ranges(),
> aren't you? If neither is suitable for your purpose, can you explain what you
> need in addition?
I understand your concern. I will check if I can refactor this patch 
using the suggested helpers. Thanks!
Kind regards,
Henry


> Jan