[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [RFC PATCH v1 0/2] convert LIBXL_DEVICE_MODEL_START_TIMEOUT to env var
On Thu, Apr 11, 2024 at 01:23:07PM +0300, Manos Pitsidianakis wrote: > Hello Anthony, > > I do know about that, in fact I used it and it did not output your > email. Here's what the `get_maintainer.pl` outputs: (same output for > all patches): > > $ ./scripts/get_maintainer.pl --no-l > ../../patches/libxl-dm-timeout-v1/v1-0001-libs-light-add-device-model-start-timeout-env-var.patch > Andrew Cooper <andrew.cooper3@xxxxxxxxxx> > George Dunlap <george.dunlap@xxxxxxxxxx> > Jan Beulich <jbeulich@xxxxxxxx> > Julien Grall <julien@xxxxxxx> > Stefano Stabellini <sstabellini@xxxxxxxxxx> Oh, sorry, I didn't realise this was "THE REST" that is the list of default maintainers. So for some reason, the script fail to parse the patches to find which files are modified. And I think I know why. Usually, `git format-patch` output something like: diff --git a/tools/libs/light/libxl_dm.c b/tools/libs/light/libxl_dm.c index 4369fef161..9ffdd50c69 100644 --- a/tools/libs/light/libxl_dm.c +++ b/tools/libs/light/libxl_dm.c with all path starting with "a/" or "b/", which get_maintainer then strip. (It strip them from the "diff --git" line, but remove the first "directory" from the path for line starting with "---" or "+++".) The patches in this series instead look like this: diff --git tools/libs/light/libxl_dm.c tools/libs/light/libxl_dm.c index 4369fef161..9ffdd50c69 100644 --- tools/libs/light/libxl_dm.c +++ tools/libs/light/libxl_dm.c with "a/" and "b/" missing, and that confuses get_maintainer.pl. It tries to find maintainers for "libs/light/libxl_dm.c" which don't exist. Did you by any chance used "--no-prefix"? It doesn't seems worse it to handle this case as I'm guessing more than on tool rely on those. Cheers, -- Anthony PERARD
|
![]() |
Lists.xenproject.org is hosted with RackSpace, monitoring our |