Re: [RFC PATCH v1 0/2] convert LIBXL_DEVICE_MODEL_START_TIMEOUT to env var

[Manos Pitsidianakis <manos.pitsidianakis@xxxxxxxxxx>]

On Wed, 10 Apr 2024 at 18:53, Anthony PERARD <anthony.perard@xxxxxxxxxx> wrote:
>
> On Wed, Apr 10, 2024 at 02:43:13PM +0300, Manos Pitsidianakis wrote:
> > This patch series proposes converting the compile-time define
> > LIBXL_DEVICE_MODEL_START_TIMEOUT value to an optionally overridden by
> > environment variable value, just like the current behavior for
> > LIBXL_BOOTLOADER_TIMEOUT is.
> >
> > Manos Pitsidianakis (2):
> >   libs/light: add device model start timeout env var
> >   libs/light: expand device model start timeout use
> >
> >  docs/man/xl.1.pod.in                 | 11 +++++++++++
> >  tools/libs/light/libxl_9pfs.c        |  2 +-
> >  tools/libs/light/libxl_device.c      |  2 +-
> >  tools/libs/light/libxl_dm.c          | 10 +++++-----
> >  tools/libs/light/libxl_dom_suspend.c |  2 +-
> >  tools/libs/light/libxl_domain.c      |  5 +++--
> >  tools/libs/light/libxl_internal.h    |  6 ++++++
> >  tools/libs/light/libxl_pci.c         | 10 +++++-----
> >  tools/libs/light/libxl_usb.c         |  8 ++++----
> >  9 files changed, 37 insertions(+), 19 deletions(-)
> >
> >
> > base-commit: f48299cad5c3c69fdc2c101517a6dab9c9827ea5
> > --
> > γαῖα πυρί μιχθήτω
> >
> >
>
> Hi Manos,
>
> Did you know that you could run something like
>     `git send-email --cc-cmd="scripts/get_maintainer.pl --no-l" ...`
> and git would CC the maintainers of the code?
>
> I've configure my xen repo to have that been automatic, with
>     git config sendemail.cccmd 'cd `git rev-parse --show-toplevel` && 
> scripts/get_maintainer.pl --no-l'
>
> There's other way to send patch, like using
> "scripts/add_maintainers.pl" described on this page:
> https://wiki.xenproject.org/wiki/Submitting_Xen_Project_Patches#Sending_a_Patch_Series
> Not sure which one is better.
>
> Anyway, I've added the series to my list of patch to look at. But I
> might miss it next time if I'm not CCed.
>
> Cheers,
>
> --
> Anthony PERARD

Hello Anthony,

I do know about that, in fact I used it and it did not output your
email. Here's what the `get_maintainer.pl` outputs: (same output for
all patches):

$ ./scripts/get_maintainer.pl --no-l
../../patches/libxl-dm-timeout-v1/v1-0001-libs-light-add-device-model-start-timeout-env-var.patch
Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
George Dunlap <george.dunlap@xxxxxxxxxx>
Jan Beulich <jbeulich@xxxxxxxx>
Julien Grall <julien@xxxxxxx>
Stefano Stabellini <sstabellini@xxxxxxxxxx>

Thanks,

-- 
Manos Pitsidianakis
Emulation and Virtualization Engineer at Linaro Ltd