Re: [PATCH v3 5/9] xen/device-tree: Move Arm's setup.c bootinfo functions to common

[Julien Grall <julien@xxxxxxx>]

Hi Jan,

On 22/03/2024 07:55, Jan Beulich wrote:
> On 21.03.2024 18:47, Julien Grall wrote:
> > On 14/03/2024 22:15, Shawn Anastasio wrote:
> > > Arm's setup.c contains a collection of functions for parsing memory map
> > > and other boot information from a device tree. Since these routines are
> > > generally useful on any architecture that supports device tree booting,
> > > move them into xen/common/device-tree.
> > >
> > > Suggested-by: Julien Grall <julien@xxxxxxx>
> > > Signed-off-by: Shawn Anastasio <sanastasio@xxxxxxxxxxxxxxxxxxxxx>
> > > ---
> > >    MAINTAINERS                       |   1 +
> > >    xen/arch/arm/setup.c              | 419 --------------------------
> > >    xen/common/Makefile               |   1 +
> > >    xen/common/device-tree/Makefile   |   1 +
> > >    xen/common/device-tree/bootinfo.c | 469 ++++++++++++++++++++++++++++++
> > The new bootinfo.c is exported quite a few functions. Please introduce
> > an generic header with the associated functions/structures.
> By "generic" you don't mean a header in asm-generic/, do you?
Right. I meant include/xen/*.

Cheers,

--
Julien Grall