Re: [PATCH v3 1/9] EFI: Introduce inline stub for efi_enabled on !X86 && !ARM

[Julien Grall <julien@xxxxxxx>]

Hi Jan,

On 22/03/2024 08:01, Jan Beulich wrote:
> On 14.03.2024 23:15, Shawn Anastasio wrote:
> > --- a/xen/include/xen/efi.h
> > +++ b/xen/include/xen/efi.h
> > @@ -31,7 +31,15 @@ union compat_pf_efi_info;
> >   struct xenpf_efi_runtime_call;
> >   struct compat_pf_efi_runtime_call;
> >   
> > +#if defined(CONFIG_X86) || defined(CONFIG_ARM)
> >   bool efi_enabled(unsigned int feature);
> > +#else
> > +static inline bool efi_enabled(unsigned int feature)
> > +{
> > +    return false;
> > +}
> > +#endif
> While fine as is for now, surely Arm32 could benefit from the inline stub,
> too.
At least for now, Arm32 provides efi_enabled(). It would be possible to 
rework, but I think this should be left in a follow-up.
Also, ideally, we would have a common CONFIG_EFI (rather than 
CONFIG_ARM_EFI).
Cheers,

--
Julien Grall