[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v6 13/15] xen/arm: make consider_modules() available for xen relocation
- To: Henry Wang <xin.wang2@xxxxxxx>, Julien Grall <julien@xxxxxxx>, Ayan Kumar Halder <ayan.kumar.halder@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- From: Ayan Kumar Halder <ayankuma@xxxxxxx>
- Date: Mon, 11 Mar 2024 12:12:24 +0000
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7elGRJ+5uZHqWxZOechfI8xXAJnZFubshb8angl6ins=; b=lfwOX9+vjuea2dQ0uEUo4wXcfBS6jdhOTxJhdZ7p6F4GLyCs9QGZWb3leIeeM/Qfs9cV4IksKUPLHALUbXfQ/SIril7dqGI96vb1p1qWvgRmkQCJSOBkWGkvkXeD+g0SAsq8jWPWK/2uGuz3vymnPuNKFh32y1EaWWQYorgFU64yS2icdlaUMW5Hoyu36wOEBUnQDUEaaVV9h/abHHBF79+OLdJVln1n2Lg3AcUUCNP7AdpBqYStkdUUD2GwOf826VNugNJgqTdT+5ZWu5ncJbCQywUzvqSXkj4KAdfbu7VUFF2YMX5q7edXHFDi9emj06uaux8CWQZUfeHf+i5oQQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FXP74RcxFOYoZ5WsbxL1BFHjDdD+rxQYaYqwVevU2A3NFoOJ1kJWmSQA7YTFOKUWGjRH7cRYwDCQlkEzPaKUF4mZswy23MBcw1JI0WBiTQsnG1KX73/Nal6lY0iHuSgnd5pY0OdGbWRA3TC16wcdFn9TBbabkAfBK1O5ycJN6XHwFWn7kQZ64P/I7aLUwBb8q31aiZFAn9QA4esXr8vzvy04H//0Ttkqae4cPMZqrGA1SrrMO8Gk1BIHxyoLiG3ucDP68zKXVV2g8eVU+H//+O1yi1LFH75rIXhx5ChR0zufZbCq8MZlY+Ap+LslO7Lxl7a65FPPiT4PlhSuYnh51A==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com;
- Cc: andrea.bastoni@xxxxxxxxxxxxxxx, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Carlo Nonato <carlo.nonato@xxxxxxxxxxxxxxx>
- Delivery-date: Mon, 11 Mar 2024 12:12:42 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 09/03/2024 06:44, Henry Wang wrote:
Hi Julien,
Hi Julien/Henry,
On 3/9/2024 6:30 AM, Julien Grall wrote:
(+ Ayan + Henry)
(- my old email address + the new one)
Hi Carlo,
On 29/01/2024 17:18, Carlo Nonato wrote:
Cache coloring must physically relocate Xen in order to color the
hypervisor
and consider_modules() is a key function that is needed to find a new
available physical address.
672d67f339c0 ("xen/arm: Split MMU-specific setup_mm() and related
code out")
moved consider_modules() under arm32. Move it back to setup.c and
make it
non-static so that it can be used outside.
Signed-off-by: Carlo Nonato <carlo.nonato@xxxxxxxxxxxxxxx>
---
v6:
- new patch
---
xen/arch/arm/arm32/mmu/mm.c | 93
+-------------------------------
xen/arch/arm/include/asm/setup.h | 3 ++
xen/arch/arm/setup.c | 92 +++++++++++++++++++++++++++++++
Ayan, Henry, will the function consider_modules() be used for the MPU
code?
I checked all the MPU branches (the recent arm64 implementation and an
arm32 branch to my best knowledge), no I don't think the function will
be used for the MPU code. However I am not sure if Ayan has a newer
arm32 MPU branch on top of the latest staging or so using the
function, Ayan would you like to add some comments?
Yes, Henry is correct.
consider_modules() is mmu specific only.
- Ayan
If not, then I think the function should live in arm/mmu/setup.c.
+1, arm/mmu/setup.c is a good place.
Kind regards,
Henry
Cheers,
|
