[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v6 13/15] xen/arm: make consider_modules() available for xen relocation


  • To: Julien Grall <julien@xxxxxxx>, Ayan Kumar Halder <ayan.kumar.halder@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Henry Wang <xin.wang2@xxxxxxx>
  • Date: Sat, 9 Mar 2024 14:44:28 +0800
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=xen.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yCnF0ak/3FNORbw4KMWfvnU4kh709Ckgp2TgFULY740=; b=AynDmcFR9cHNxYzHSRsNVR76Ct3NcZUz1zjbhAyW3Elhj69qmHVaxY6y6bW24a2OzuidYZ+dv0pkdZgtIiyOn9F6QqUhkEtmnkm2z3NwiBazJ79DO5pwkNLnuaXa1RtcZiWaBVYBqf5ScRjdpk51edZ/4+rvfF/aL4PKosKdrcbid7IuZfhgFRcYbKpP/hjcMkZh9i2hXdn4YL1wZoHooV9iKzpD6mNmzcplJpBNs9TS5J31S30cz09oxswp2QkJkaPwaloRjyIWEjGL2ebE+ImAFhJQmbbZMmTNuLK7Q0qIS7GlSqcbBWC0SPGkbWwlReSeffFSuiZikOC9f2BfVw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=O+/PE5nEYDTuultTWUFL5vUR39hl7X+K+C9GmNg5FZ/iHRmEwRD/0I8/qilqDGWGpl9RtXOThStexzhQOoPRQlyAD17weolc3uBjCcwP4DHip3ATBah46wRXjo8ovzXU29tASbxfTTa5WQ7bg7aK/OsbWI4UX+RiWi5hYQxjpysBkVC/FV5wGNA29zExUQg1bGTAkUxQJ6ctBC5TQAl/neNZc0mrKqJfMLlhagGpg6UgSPXWHKU6pDlTQbEpLTQx3i26CPoFtR8gqdu0SGWlLOF4EoX7LnHN0z6Jj/RcK52tEUX0eoZKkyBmxFF0c4OWAhUFVI+pXWc1e8P+TQKcWQ==
  • Cc: <andrea.bastoni@xxxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Henry Wang <xin.wang2@xxxxxxx>, Carlo Nonato <carlo.nonato@xxxxxxxxxxxxxxx>
  • Delivery-date: Sat, 09 Mar 2024 06:44:45 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

Hi Julien,

On 3/9/2024 6:30 AM, Julien Grall wrote:
(+ Ayan + Henry)

(- my old email address + the new one)

Hi Carlo,

On 29/01/2024 17:18, Carlo Nonato wrote:
Cache coloring must physically relocate Xen in order to color the hypervisor
and consider_modules() is a key function that is needed to find a new
available physical address.

672d67f339c0 ("xen/arm: Split MMU-specific setup_mm() and related code out") moved consider_modules() under arm32. Move it back to setup.c and make it
non-static so that it can be used outside.

Signed-off-by: Carlo Nonato <carlo.nonato@xxxxxxxxxxxxxxx>
---
v6:
- new patch
---
  xen/arch/arm/arm32/mmu/mm.c      | 93 +-------------------------------
  xen/arch/arm/include/asm/setup.h |  3 ++
  xen/arch/arm/setup.c             | 92 +++++++++++++++++++++++++++++++

Ayan, Henry, will the function consider_modules() be used for the MPU code?

I checked all the MPU branches (the recent arm64 implementation and an arm32 branch to my best knowledge), no I don't think the function will be used for the MPU code. However I am not sure if Ayan has a newer arm32 MPU branch on top of the latest staging or so using the function, Ayan would you like to add some comments?

If not, then I think the function should live in arm/mmu/setup.c.

+1, arm/mmu/setup.c is a good place.

Kind regards,
Henry


Cheers,





 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.