[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH] xen: add acmacros.h to exclude-list.json
- To: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
- From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
- Date: Tue, 19 Dec 2023 11:09:56 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tlrBFriPsXkB3qHDYp25yU4rCzS8l4pf0tcegfHsrJw=; b=QYIq0Q7I7y0AvL2GjQalA7tCn3bhBsQqezJJXNrzH2YNo0wuUz06pIUHQcK8uC0AxhJZNH5pkSBXzpDymiRgA7ssRj07hcEhXbBXwR8dOxp2h56tdA/dm9QLi3HROmJKvsf82Kf0++t4u1j/nXcZW6HwARa1yvr8Bcz/PRf4/EKXRENcfh4Q5M2XeOn2P+2G9qouncbm1J7ngqj5xV4Kc84Vx4fVxPVK1leNdDuR8/e3Fl6CyfqjlM5uQftZGyJ+dQhYFIcW2hqdOMC0YL/DwzMTAzodNkNzBmM34cbbBu60O4loeI0N/G43PmiPYJDPWztUPr6tlT5J3T8ovQsajg==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tlrBFriPsXkB3qHDYp25yU4rCzS8l4pf0tcegfHsrJw=; b=gU0KIDN6tojn4Iz9aBJfrqgEPbJc/81k8vf6whtog5YX0WCw9gulfqT6vGTQ8RLCzs19GqQP6RKdPv89DvAy5ZvkA1OWJuw1Cy+Po1tpPdxjz/8YbKobrDa8wsiV0GIlUTfJ56nNLjc4viGF3bggVZNUeesCVLrmblBljxsyIHnNhdhhC1YqoVxiz/ZWYH9BQOH5Oy2XZl+mcVbDQr5thpMsIYggKxqCu99Lb366nHzc28HWCY0k4VhBK8DRznSSzmjjCJIbViH66bJ76jLTVdlplQMP7/S51Jik4kjcg7dteOgdXW5/9EG3+EO1CQ4eg1I0MrFwYqUPEf4sWg0tSQ==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=lVNsqCxUgnENJgzA9fYR/xZMVDWpY41FvQPtO/UqEA0/ysIvuYZQ2Tfa2Idq2T+vSfAOB8Xm+cjtOnwBYwDhLxM/A5Luju5Z5riu9MU9NrZSuKgMubNulp+XY+wNURO5GtUtTeYpIA9ziQGbTp98QkD40P4hX45lf/ulk3oeXSPixczat5hqzZsYMSuaVUdsPLNmtyJ+QB6NpCeC3CClVG07bS1+XEZhYexOOTFQCcgWKmaf3If81hJ41kXPmuGKi98HZDub2ISiL082NZV9cMwAuMvHYQpX6fa8d8zj0ygts3lAi3BBLrJw6guJkk8pY9OXSVgCmOangUJ12QkdgQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TtOVbTWEjRVcVGz9XDEgj5NYVy4dDMPWnIpeEIjIGvoYjZ4BUQXrLXvkxbJDRamIQYJ6TjAQ5SnGsjM8KOVhBhbW3pY6wV79f7xdfBXNNDbWn09E3UUiEyDkFKV3PrjLasSn977ZD2kvzWE0rATsVLQ49jliODtZFyfZiraxA9aIlTbBj/q4N5SL746JFxm0ZmkuHUhSGtVsuc0zm/tR0+puKPRJelQ7KNtNE1PbO454pKZDL7rm1wVBcFwb218XqfpC0oxnTtBFgDGm4wrk6Duxyy02BrpoOQK+uSmScAipOJAHXyHKdsuXv0e75jBl+/GApRWZQE6Mo2Hw2qjWtw==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Jan Beulich <jbeulich@xxxxxxxx>, "consulting@xxxxxxxxxxx" <consulting@xxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Tue, 19 Dec 2023 11:10:23 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHaMmldSNcDtDpNs0m0RNrxIeAVZrCwcdKAgAABGYA=
- Thread-topic: [XEN PATCH] xen: add acmacros.h to exclude-list.json
Hi!
> On 19 Dec 2023, at 11:05, Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx> wrote:
>
> On 2023-12-19 11:51, Nicola Vetrini wrote:
>> On 2023-12-19 11:37, Jan Beulich wrote:
>>> On 19.12.2023 10:02, Nicola Vetrini wrote:
>>>> --- a/docs/misra/exclude-list.json
>>>> +++ b/docs/misra/exclude-list.json
>>>> @@ -209,6 +209,10 @@
>>>> "rel_path": "include/acpi/acglobal.h",
>>>> "comment": "Imported from Linux, ignore for now"
>>>> },
>>>> + {
>>>> + "rel_path": "include/acpi/acmacros.h",
>>>> + "comment": "Imported from Linux, ignore for now"
>>>> + },
>>> Together with what's already there (in context), wouldn't it better be
>>> the entire directory then which is excluded, or at least all
>>> include/acpi/ac*.h collectively (and perhaps also
>>> include/acpi/platform/ac*.h)?
>>> Jan
>> +Cc Luca Fancellu
>> Sure. I wasn't certain which files are imported from ACPI CA and which
>> aren't.
>> I'm also not sure whether "include/acpi/ac*.h" would be properly recognized
>> by other tooling that uses exclude-list.json (only cppcheck I think). I
>> Cc-ed Luca Fancellu on this.
>
> It occurred to me that it's surely ok to use "include/acpi/ac*" and
> "include/acpi/platform/ac*".
Yes I think it’s fine, it just come to my mind now that this could have the
risk that if
another file is added with ‘ac' prefix, even if it could be subject to MISRA
compliance,
it will be excluded.
If that risk is negligible for the maintainer of that part, then it’s fine.
>
> --
> Nicola Vetrini, BSc
> Software Engineer, BUGSENG srl (https://bugseng.com)
|
