Re: [PATCH v2] xen: remove <asm/delay.h>

[Oleksii <oleksii.kurochko@xxxxxxxxx>]

On Wed, 2023-11-15 at 11:24 +0100, Jan Beulich wrote:
> On 31.10.2023 15:28, Oleksii Kurochko wrote:
> > <asm/delay.h> only declares udelay() function so udelay()
> > declaration was moved to xen/delay.h.
> > 
> > For x86, __udelay() was renamed to udelay() and removed
> > inclusion of <asm/delay.h> in x86 code.
> > 
> > For ppc, udelay() stub definition was moved to ppc/stubs.c.
> > 
> > Suggested-by: Jan Beulich <jbeulich@xxxxxxxx>
> > Signed-off-by: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
> > Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
> > ---
> > Changes in v2:
> >  - rebase on top of the latest staging.
> >  - add Suggested-by:/Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>.
> >  - remove <asm/delay.h> for PPC.
> >  - remove changes related to RISC-V's <asm/delay.h> as they've not
> >    introduced in staging branch yet.
> > ---
> >  xen/arch/arm/include/asm/delay.h  | 14 --------------
> >  xen/arch/ppc/include/asm/delay.h  | 12 ------------
> >  xen/arch/ppc/stubs.c              |  7 +++++++
> >  xen/arch/x86/cpu/microcode/core.c |  2 +-
> >  xen/arch/x86/delay.c              |  2 +-
> >  xen/arch/x86/include/asm/delay.h  | 13 -------------
> >  xen/include/xen/delay.h           |  2 +-
> >  7 files changed, 10 insertions(+), 42 deletions(-)
> >  delete mode 100644 xen/arch/arm/include/asm/delay.h
> >  delete mode 100644 xen/arch/ppc/include/asm/delay.h
> >  delete mode 100644 xen/arch/x86/include/asm/delay.h
> 
> Shawn: As per the diffstat below your ack is needed here. Recently I
> did
> (silently) time out on two sufficiently trivial (PPC-wise) patches,
> but
> this shouldn't become a common pattern.
> 
> Oleksii: It is normally on the submitter to chase missing acks.
Probably it wasn't right but I sent a private e-mail to Shawn last week
with the request. I'll do it publicly next time.

~ Oleksii