Re: [PATCH v2 02/29] tools: add a new xen logging daemon

[Juergen Gross <jgross@xxxxxxxx>]

On 13.11.23 18:36, Jason Andryuk wrote:
> On Fri, Nov 10, 2023 at 11:08 AM Juergen Gross <jgross@xxxxxxxx> wrote:
> > Add "xen-9pfsd", a new logging daemon meant to support infrastructure
> > domains (e.g. xenstore-stubdom) to access files in dom0.
> >
> > For now only add the code needed for starting the daemon and
> > registering it with Xenstore via a new "libxl/xen-9pfs/state" node by
> > writing the "running" state to it.
> >
> > Signed-off-by: Juergen Gross <jgross@xxxxxxxx>
> > ---
> > --- /dev/null
> > +++ b/tools/xen-9pfsd/xen-9pfsd.c
> > @@ -0,0 +1,145 @@
> > + * The backend device string is "xen_9pfs", the tag used for mounting the
> > + * 9pfs device is "Xen".
> '_' is much less common in xenstore node names than '-'.  Is there a
> particular reason you chose '_'?  I generally prefer '-', but IIRC the
> libxl idl can't handle '-'.  Did you hit that?
Yes.

> Reviewed-by: Jason Andryuk <jandryuk@xxxxxxxxx>
Thanks,

Juergen

Attachment: OpenPGP_0xB0DE9DD628BF132F.asc
Description: OpenPGP public key

Attachment: OpenPGP_signature.asc
Description: OpenPGP digital signature