[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [XEN PATCH][for-4.19 v4] xen: address violations of Rule 11.9



On 2023-11-06 15:27, Jan Beulich wrote:
On 06.11.2023 15:24, Nicola Vetrini wrote:
On 2023-10-19 09:55, Nicola Vetrini wrote:
The constant 0 is used instead of NULL in '__ACCESS_ONCE' as a
compile-time check to detect non-scalar types; its usage for this
purpose is deviated.

Furthermore, the 'typeof_field' macro is introduced as a general way
to access the type of a struct member without declaring a variable
of struct type. Both this macro and 'sizeof_field' are moved to
'xen/macros.h'.

No functional change intended.

Signed-off-by: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
Reviewed-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>
---
Changes in v2:
- added entry in deviations.rst
Changes in v3:
- dropped access_field
- moved macro to macros.h
---
Changes in v4:
- Amend deviation record.
---

This patch has received some R-by-s, but no acks at the moment.
Perhaps at least one is needed to get this into 4.19?

I didn't think it does, and I have it marked as ready to go in. But
from an earlier email from Stefano I inferred that it might be
preferable to commit larger sets of Misra changes only once the tree
is fully open again.

Jan

Ok, thanks for the clarification.

--
Nicola Vetrini, BSc
Software Engineer, BUGSENG srl (https://bugseng.com)



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.