[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH][for-4.19 v4] xen: address violations of Rule 11.9
- To: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Mon, 6 Nov 2023 15:27:59 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zbzF92ZsPyTGKT4HUFdTx0UvVSW1J+2BxcYu8QUCqyQ=; b=fE3RJ9rqTCCFHzRhbBgHEFxA4JtNo1AJAShYzfiStEouHRKMpTfEV2UJSx/TE7jNAhAp0Gk22gV/SRfVmZXra2P2vJ4hyp/rNqVp22pH2Pwh9RJWGyopUsibyXbOt023f8mtrN2zx1VQkPxfzgZe81SAv5+X8ZOPxHrD0MUgLNQEqeL+z+Nd2yg91AJF5zaBVnbNonVGuYmo+YdqTcOimrsvXn1oV10Xbz+LMbUp5BOvQSI0XZXsz6NjyIS+ihQfOWwV8nxGTI46Ilrpt2/5xeERUBa4kIDj++QL512cuRIUr/keCzQCSVECatNiVXy7O+9DQxh9PaBZnBD4FPc4Vg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=J9x9sB4TV7IReacBntZ9W6hHLZIA7xCWXJEzgpdl/eRFNGYku5bgolIc2wZF9MzFq32Gn1rNymf/9m512+ljJoLY7roNf5I+cDcXojSD3PJ+tx5jzUX13evRsAg34GuWTuY1ldZu/lOezCotzQyyJhFwiC/3vcfGfv8cyIZRyfF6aWZ6U0Gg2aMH7D/sghIhHlQG5gUwe2A2jkRWyDe/C62KbrwO9SWGteBG4D7stV+AzhnY22jdBUd6Kx6EKXP992PIVKfGMXqCZzreQNU9QAFav8Q6FXZSGtTr2sO8SpC+PjxJHtKudkWp4V7b3VNnZN26yMNoxrPFurcMYwN/PA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: sstabellini@xxxxxxxxxx, michal.orzel@xxxxxxx, xenia.ragiadakou@xxxxxxx, ayan.kumar.halder@xxxxxxx, consulting@xxxxxxxxxxx, andrew.cooper3@xxxxxxxxxx, roger.pau@xxxxxxxxxx, Simone Ballarin <simone.ballarin@xxxxxxxxxxx>, Doug Goldstein <cardoe@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Mon, 06 Nov 2023 14:28:12 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 06.11.2023 15:24, Nicola Vetrini wrote:
> On 2023-10-19 09:55, Nicola Vetrini wrote:
>> The constant 0 is used instead of NULL in '__ACCESS_ONCE' as a
>> compile-time check to detect non-scalar types; its usage for this
>> purpose is deviated.
>>
>> Furthermore, the 'typeof_field' macro is introduced as a general way
>> to access the type of a struct member without declaring a variable
>> of struct type. Both this macro and 'sizeof_field' are moved to
>> 'xen/macros.h'.
>>
>> No functional change intended.
>>
>> Signed-off-by: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
>> Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
>> Reviewed-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>
>> ---
>> Changes in v2:
>> - added entry in deviations.rst
>> Changes in v3:
>> - dropped access_field
>> - moved macro to macros.h
>> ---
>> Changes in v4:
>> - Amend deviation record.
>> ---
>
> This patch has received some R-by-s, but no acks at the moment.
> Perhaps at least one is needed to get this into 4.19?
I didn't think it does, and I have it marked as ready to go in. But
from an earlier email from Stefano I inferred that it might be
preferable to commit larger sets of Misra changes only once the tree
is fully open again.
Jan
|
