Re: [PATCH 02/29] tools: add a new xen logging daemon

[Jason Andryuk <jandryuk@xxxxxxxxx>]

On Wed, Nov 1, 2023 at 10:27 AM Juergen Gross <jgross@xxxxxxxx> wrote:
>
> Add "xenlogd", a new logging daemon meant to support infrastructure
> domains (e.g. xenstore-stubdom) to write log files in dom0.

As I understand it, your new daemon is a generic 9pfs backend, which
you use for logging.  I think naming it something like xen9pfsd would
more accurately describe its functionality.

> For now only add the code needed for starting the daemon and
> registering it with Xenstore via a new "/tool/xenlog/state" node by
> writing the "running" state to it.

To support driver domain use cases, I think you want to use a relative
Xenstore path.  While this daemon is independent from libxl, it might
be easiest to use "libxl/xenlog/" ("libxl/xen9pfs/") to take advantage
of driver domains having a read-write "libxl/" directory.

> Signed-off-by: Juergen Gross <jgross@xxxxxxxx>

The code looks good to me.

Regards,
Jason