Re: [PATCH v8 8/8] xen/arm: mmu: move MMU specific P2M code to mmu/p2m.{c,h}

[Julien Grall <julien@xxxxxxx>]

Hi Henry,

On 23/10/2023 03:13, Henry Wang wrote:
> From: Penny Zheng <penny.zheng@xxxxxxx>
>
> Current P2M implementation is designed for MMU system only.
> We move the MMU-specific codes into mmu/p2m.c, and only keep generic
> codes in p2m.c, like VMID allocator, etc. We also move MMU-specific
> definitions and declarations to mmu/p2m.h, such as p2m_tlb_flush_sync().
> Also expose previously static functions p2m_vmid_allocator_init(),
> p2m_alloc_vmid() for further MPU usage. Since with the code movement
> p2m_free_vmid() is now used in two files, also expose p2m_free_vmid().
>
> With the code movement, global variable max_vmid is used in multiple
> files instead of a single file (and will be used in MPU P2M
> implementation), declare it in the header and remove the "static" of
> this variable.
>
> Also, since p2m_invalidate_root() should be MMU only and after the
> code movement the only caller of p2m_invalidate_root() outside of
> mmu/p2m.c is arch_domain_creation_finished(), creating a new function
> named p2m_domain_creation_finished() in mmu/p2m.c for the original
> code in arch_domain_creation_finished(), and marking
> p2m_invalidate_root() as static.
>
> Take the opportunity to fix the incorrect coding style when possible.
> When there is bit shift in macros, take the opportunity to add the
> missing 'U' as a compliance of MISRA.
>
> Signed-off-by: Penny Zheng <penny.zheng@xxxxxxx>
> Signed-off-by: Wei Chen <wei.chen@xxxxxxx>
> Signed-off-by: Henry Wang <Henry.Wang@xxxxxxx>
Acked-by: Julien Grall <jgrall@xxxxxxxxxx>

I think the series is now fully acked. But I will wait for 4.18 to be 
released before merging this series.
Please remind me in a couple of weeks time if I forgot to merge it.

Cheers,

--
Julien Grall