[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN] xen/arm: arm32: Use adr_l instead of load_paddr for getting address of symbols
- To: Ayan Kumar Halder <ayan.kumar.halder@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Michal Orzel <michal.orzel@xxxxxxx>
- Date: Wed, 25 Oct 2023 19:59:09 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CUJAaqaEQoITOwXoOnoWyu97lWfwQAB2uYghglTAPMo=; b=UXd72RJ5jBh+lK2umohEhpgQ2rtboOhRQkJniceRgKRoRRfRGRRFw0N6gLskVlxWPWUh0zH73S4aovu/svyR7Ronn28xZw4gcdwzVtSu1zzh7qcy3/O5X9xG5bbT554UbqFCkyE+cNfIuJIO1LU1FlHtiEc5K/nWPwAmPjanWTckwr/mDHl1/nIBIOVYeghOdYvac6kd39QzOL16VJIMiTIFbkMaqRLAcCRRpN1ZYHXYY/OgHGNWFmsIpJEpVOeKZlfWLmC8USXjjGYU99WOTti0WRZYI024KivH1wtUifLQPNQisN2kskYi8vXVuRVeX+AE+Tq+DDys4NeOMjMAqQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=T0kBuw4X1K9vD4qC6RekqvSHAdUQZUrH9FFez1p+dNAbQPjZFLyqZ8kWzizUfajYLD7LSp3WjOPIoIfrzsHEKZIQrkub5kj0GcKfc3l1CdiCTjzSl1fiTZcJFej9PfIM+ogZT/y2rybCwG/Kw22yvBKWkBT2+PV8iGVGxT+fQ4J5dYveKd9yG+byPkGH4SSGpgBGC04jgV8Qi7IeouhSTXV03Gb4ET3UVvBXtiGtTWRT8gNmNwlTqy1R0by5lsG/hxOmn1u1mfzJxlkX2/Rm+yfx84AQY60bsyxGsiFrkDWmCTiRzKvAC5rsxdYaq/71m9cyrGM9YwCy6RP21Hsh9A==
- Cc: <sstabellini@xxxxxxxxxx>, <julien@xxxxxxx>, <bertrand.marquis@xxxxxxx>
- Delivery-date: Wed, 25 Oct 2023 17:59:29 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
Hi Ayan,
On 25/10/2023 19:03, Ayan Kumar Halder wrote:
> Before the MMU is turned on, the address returned for any symbol will always
> be
> physical address. Thus, one can use adr_l instead of load_paddr.
>
> create_table_entry() now takes an extra argument to denote if it is called
> after
> the mmu is turned on or not. If it is called with mmu on, then it uses
> load_paddr to get the physical address of the page table symbol.
I wonder if we need this extra complexity.
Can we just remove load_paddr macro completely (I have a plan to do this for
arm64 mmu head.S)
and open code it in create_table_entry? I don't think there is any benefit in
having the if/else there to use either load_paddr or adr_l. This function will
also go
into arm32 mmu head.S.
~Michal
|
