[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [for-4.19][PATCH] build: Allow setting KBUILD_DEFCONFIG in the environment
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Michal Orzel <michal.orzel@xxxxxxx>
- Date: Wed, 25 Oct 2023 11:21:29 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=suse.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/UiioaXloc+8FEJy+zcjhibtF1PbYvv06pqt/tf7RQY=; b=brChlVtaY+5yxf89lSzQmfKn9WtbowMn9xoD0Fk402FT2WH29vka2IZfeDu3I4Tj0Vie9wUx5/ydRNSDCoP29ctz6FIOpGNbZbkCTH4lnm5nGC/5nMtUTwjKj2bsqOjeO5SI3XxX9BymFATI4C7JzniQTvx9M2O/X5vkA6HLwHBnOs29+RIXoaechzN8PfRrAllGbyVf4KjROKxGWq0LIfX/cUvD6ENFmTh2Ve2oYHSd2r7uUaQvDy+mmx+VE1B4a22MuwaSAJAJ3jPZUQX6pcXR/cVIDC2u9ytL39JIwZEx3bG3lTo8C/QgSJzbHO3DudcGby/hHeC7yLNlntDDxQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CydTf7+zTKxFF4uaBEYSpkmxTRYA/cgph2sSr0jKz4ISc2iAwSdiYhb3HL5bUMcfP0q4km8u3SKHup2SKxqkGC40agjw07gmPdMejpGRk8+KBNk6L6A8RUsZiZcIG6hyTQM9bQG4VTKJWDgH13T4g14CAfFTSt+N6WnmFbx7cGd6wyJfKEqI0Vew2B5nRo2O1VdD1zWdWbpbjMr2roXCflr87dWhqpUVCWOucY8ic9ftbzUoNUdm0pmWJNgR/JjYjNdAaRtAfKbM7Fc6gFsHypCy0j27thdAbVeLOk5JRCLRwJbmsmcfnlNcGI2dcl2m8QIwa6CEvCvW2dG3e1diNw==
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Wed, 25 Oct 2023 09:21:53 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
Hi,
On 25/10/2023 11:10, Jan Beulich wrote:
>
>
> On 25.10.2023 10:28, Michal Orzel wrote:
>> At the moment, in order to use a different defconfig target than default,
>> one needs to specify KBUILD_DEFCONFIG=<target> on the command line.
>> Switch to weak assignment, so that it can be also obtained from
>> environment similar to other KCONFIG/KBUILD variables.
>>
>> This change will activate the use of KBUILD_DEFCONFIG variable in CI
>> build jobs that so far had no effect.
>
> I'm certainly okay with the change, but the above sentence looks misleading
> to me: Yes, the envvar was ignored so far, but isn't it the case that the
> envvar as specified in CI matches what Makefile set it to (taking into
> account that for RISC-V riscv64_defconfig aliases tiny64_defconfig), and
> hence the specifications in build.yaml could be dropped (until such time
> where truly an override was intended)?
Well, today riscv64_defconfig matches tiny64_defconfig but it can change.
Otherwise, why
would we need to have 2 identical files? Looking at the latest full build
series from Oleksi,
only the tiny64_defconfig file gets updated which would be the clear indication
that what is
specified in the CI matches the author's expectation.
Also, I never mentioned that this change fixes something. I just wrote that it
gives a meaning
to a variable that so far had no effect.
~Michal
|
