[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH v2 00/10] address violations of MISRA C:2012 Directive 4.10
- To: Stefano Stabellini <sstabellini@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Wed, 25 Oct 2023 10:18:14 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yfe9SUBkQjC3NVIKgSgfgo08Sk/dCBtM8YEv6cZMioA=; b=M7ysaQ1q6KHUNxLVvNfJwMsF+mb0/FvktGLgVBOAqG0AzzmPvVmzoRzfB9d4x6wScD2pBUotYpxrGGQbSB4QESdYuCoX1XThxS3YWkg08KGgxnDZw9/+uOwr5uV8zlLITlQl6y1z21lfCUdNTGKk+5Z7mohfEpnyZm8Z/IQvo3xaolbc2xujrP5juVFgP2kQ+T4aLfGNfIaad+OTCOi+POy+dHhl70cvfKUlyOS3Fv+wRlu7RvORHBhLo1DQK4f4c5BzC55GXgozKGNimoZuNcMnX4dzR5psNuKRbIEA8nuBFkGcbFkxKZm6Od9CSxjCp+AzmZ0smieRX7QIQuAbWQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UmU5hm5eHhZjflXxOh/p3MZ2gVxIZyb+/pRQoHKT5WaxO15B88Hg25H/DL73RIOFxFIO5+1HY5zlU42T28QX6yxZtIWBnkfr8Jf1w5F1wV9kbrn+PE4hF4D2FqKaby5qKVfzj77cwiMIXOe0EsGUWgRNTCypLtQ1t1vfmyZbabd8fNLQdeIr3hML9uuQJRx8OpnitVo2vZtscUQAZnUxc7QhSylTGfA7zxrxrjCcmDypGWz+Aa0umhbrFMXdCQgMHvm1NSkD7jz+VqNohPexoKBygSKl4OfpDomi27X3oqeXfGeVoeSDYHFce5Qx0l410VTKZGX3Hfcqv78GxWO/Wg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Julien Grall <julien@xxxxxxx>, Stefano Stabellini <stefano.stabellini@xxxxxxx>, Simone Ballarin <simone.ballarin@xxxxxxxxxxx>, consulting@xxxxxxxxxxx, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Doug Goldstein <cardoe@xxxxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Wed, 25 Oct 2023 08:18:56 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 24.10.2023 21:59, Stefano Stabellini wrote:
> If I understood correctly I am fine with that. To make sure we are all
> on the same page, can you provide a couple of samples?
Taking the earlier example, instead of DRIVERS_PASSTHROUGH_VTD_DMAR_H it
would then be VTD_DMAR_H. arch/x86/pv/mm.h would use PV_MM_H, but then
you can already see that a hypothetical arch/x86/mm.h would use X86_MM_H,
thus colliding with what your proposal would also yield for
arch/x86/include/asm/mm.h. So maybe private header guards should come
with e.g. a trailing underscore? Or double underscores as component
separators, where .../include/... use only single underscores? Or
headers in arch/*/include/asm/ use ASM_<name>_H (i.e. not making the
architecture explicit in the guard name, on the grounds that headers
from multiple architectures shouldn't be included at the same time)?
Jan
|
