[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN RFC] xen/automation: add deviations for MISRA C:2012 Rule 8.3
- To: Federico Serafini <federico.serafini@xxxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 24 Oct 2023 16:32:29 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=a4xgN67JX1LpSLOq1u/CDoxkvGoPVuHYeQs/ulLj/8I=; b=Xl4f0tCA/oDIGYCdEgu0GuX/Hw68vRhXiwHWHzYBTXVOAYtojofZbieO/qR+8v/y+YvvLsYajnE/QBPtZwFwqG8edo8ruXJtcGGtJVwzG+6W1JoeZojozSjeRiLIBKi+pvsRMDiEP11pqbKmhmWE/tWHw1+D84uUYDWXqebcM/U2Aq4NGR8vlsAqAodB11z8Emr1DUQYP96Nog5leImkY1kXpxmBl3oFUfO6EtWDs/VFme3R2TStfpEBTsj8sUCcfTvoXtUHDgZ63wAVhXjND5I16w5d77RV5jkEe6jc9M3WrGdbde2AnhKyGfTGTWTrssNVP4slj47ZC+NS3txUTQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WDmLBvha/0zPSt3FiAYYEzTH3Vshnjkc01Y6LG9FVg29neYf2lqgYC2EyNqYBFN2OkI22vytJl9o3g5rOFxPjteoyPhOZY5rR4gYkMlmsKtbmIyV31eiRMIewVnj+9pgjMEJwdRA805vzmjH8N3iMyZNHLxCv9KhaZFea2/ZjMO0erSy7ELNxOeLJD+Vr+i0k5vpi/NsS0XbzMAwSJYyEImybis8MkbefCTKP8Z7dt1J7/UOwIJ7gwKFpQvK+6OUAJicLgRnLH68qX7NoTo8U4/+NSKkd0HgklR5RDEShP725LS0+ZvX7bxIqdLZXFcGuDQZf8MOmjFkr2LeCq5VSg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: consulting@xxxxxxxxxxx, Simone Ballarin <simone.ballarin@xxxxxxxxxxx>, Doug Goldstein <cardoe@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Tue, 24 Oct 2023 14:32:37 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 24.10.2023 15:22, Federico Serafini wrote:
> Update ECLAIR configuration to deviate Rule 8.3 ("All declarations of
> an object or function shall use the same names and type qualifiers")
> for the following functions:
> - set_px_pminfo();
> - guest_walk_tables_[0-9]+_levels().
>
> Update file docs/misra/deviations.rst accordingly.
> No functional change.
>
> Signed-off-by: Federico Serafini <federico.serafini@xxxxxxxxxxx>
> ---
> I had a discussion with Jan about the reasons behind the choice of parameter
> name 'walk' for the definitions of functions guest_walk_tables_[0-9]+_levels()
> and the parameter name 'pfec' for the corresponding declarations.
> Also for the function set_px_pminfo(), it seems that the parameter names are
> different on purpose.
In this latter case I wonder why you think so. Did I end up making a
misleading comment anywhere? It looks to me as if naming the parameter
in question "perf" uniformly would be quite okay.
Jan
|
