[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH][for-4.19 v4 2/8] x86: add deviations for variables only used in asm code
- To: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 24 Oct 2023 09:32:45 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EoE+HlxyflzzrXrf020OIhd/O5HLKXz2JsuOu1NaoJk=; b=bpX1Dw46aJZI77C6tr6mJnKapjCspCWs0hLLD6UXsp2Vz2ZD8cMTu9B/w9K9zDcHjrk9LhfWcf2Y200rbUhlXHwWGMl5QgRppkl9ct0MOOUJxdmD7IdjxO3F8OZ+rNlujmm/EtedvxpQTjXk7xsc6cuGCKuUAbuPgtIWRFp11j368cf/KIXT7Sqv35lm4HdvHTxMpa4ax/80bIzd5EVJkQ5t3fmSS98HzVE6RH0zIwlHS15Dl0l4RnUmi4XqBsCOn1BkvST78WQ8U+2TNS8Mh2W5ks/jZzGzv+BP2ZzAnNGJNcankPtfAs0Z2zihHAxw+LhKv8rAa8ktUMuRZJVxtA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=i1jDnMNfRpsSkhITwz65E1nRrpHpbJOdJ8mr5OgySeTqpMDnNA0BthQ4GVREIC+kOTyDbB6mMFXpfmIX+r+dYA5Sa94n5aHujYtdhjDjRmRaX9ZlvukWgVpVH0DvXVQs3+5AlTq2LYmAmMaXAGzAD+XBK/LGe3bVAKMV7bK6EaMCQBekSvN35FlXd6bBg3ISiL/c3nNxNqlLwJMtWa7hmCgVXGe7TsBuxDi6EgGiwVj1Wm4rJ+0z/kB77OwvYRengD3mjcEPXUmg2WRAPRqAWu7YyxXUqgjYZqThIzGL+7uzyH9oTBtOBfbUV2xyg2qh/0QLqGkiAgls3m8PY2TSTA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: sstabellini@xxxxxxxxxx, michal.orzel@xxxxxxx, xenia.ragiadakou@xxxxxxx, ayan.kumar.halder@xxxxxxx, consulting@xxxxxxxxxxx, andrew.cooper3@xxxxxxxxxx, roger.pau@xxxxxxxxxx, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Tue, 24 Oct 2023 07:33:29 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 23.10.2023 11:56, Nicola Vetrini wrote:
> --- a/xen/arch/x86/include/asm/asm_defns.h
> +++ b/xen/arch/x86/include/asm/asm_defns.h
> @@ -31,6 +31,7 @@ asm ( "\t.equ CONFIG_INDIRECT_THUNK, "
> * gets set up by the containing function.
> */
> #ifdef CONFIG_FRAME_POINTER
> +/* SAF-1-safe */
> register unsigned long current_stack_pointer asm("rsp");
> # define ASM_CALL_CONSTRAINT , "+r" (current_stack_pointer)
> #else
SAF-1-safe is about symbols "used only by asm modules". This doesn't apply
to the declaration here.
> --- a/xen/arch/x86/setup.c
> +++ b/xen/arch/x86/setup.c
> @@ -75,6 +75,7 @@ static bool __initdata opt_invpcid = true;
> boolean_param("invpcid", opt_invpcid);
> bool __read_mostly use_invpcid;
>
> +/* SAF-1-safe Only used in asm code and within this source file */
> unsigned long __read_mostly cr4_pv32_mask;
>
> /* **** Linux config option: propagated to domain0. */
> @@ -147,12 +148,13 @@ cpumask_t __read_mostly cpu_present_map;
> unsigned long __read_mostly xen_phys_start;
>
> char __section(".init.bss.stack_aligned") __aligned(STACK_SIZE)
> - cpu0_stack[STACK_SIZE];
> + cpu0_stack[STACK_SIZE]; /* SAF-1-safe Only used in asm code and below */
Wasn't it that such comments need to live on the earlier line?
Jan
|
