[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 1/2] domain: fix misaligned unmap address in {,un}map_guest_area()
- To: Roger Pau Monne <roger.pau@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Mon, 16 Oct 2023 14:30:12 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kJJZYpGMDMpQMlOlxJZmj0caqqy/PauBGDU89vQIbh8=; b=jCgAIu7LLBr8pjqSVHxNfjbqUpl8zZnWARLO8NNC4ezG8hg6UCqANjU6yp/t/3wXdMFgsk0bfNSaXNkT6zcjCEpXfx8/aECyB6+98vjsWHHdOR80iTkoYBdsWkEZI3O1cxuW5HgQXDf+FKUtVIePYawRuAn0Fz1kbHRtczhp9EqTlqJA2dWGpiitiorT8NvhYvBziZxkx++srIyG4rixrLsPZYK0NSQicnhXkrQnhDlWyUqKhV9+yAk7JRgCIikFb5caIpndCRgtSsNqpu49qCZqc+KuyQMHpMcoCvv5DFagDWNPx32OiASox6sPLR7mKeyQ+2sR6gNsKJFcsBGj0Q==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hU9OulXySWClVarA13522OEIVnIhDBSE6P+4Cfdvhd0kS1ur+ZKEihCzllsztgpv3MLL23iy3YhvR3vWpC76Ge+Yihmv6XO/IM41/UYj9hjw9T6SikxGHJdqqroDdLkefMWwULo/1zW1jYSr19no+vxKeThiv2otU98L+qtBRBlld1FRVfCuTQG4ay+YPsdRUwaRzf9tKJAGDMuog5FLr9kSYcE9vHAq1Nq02bDN5/ZLs4wxTb7l7ymVM2XjuxlGvlD+oo8WvXD9Qi8XEMnFrtnTqcrlCmlvpJu6rOvRTTR1eO434FBNxyN7oUrZh0RTK+mC2YIxQqMr3n94Bh04Sg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Henry Wang <Henry.Wang@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Mon, 16 Oct 2023 12:30:34 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 06.10.2023 15:00, Roger Pau Monne wrote:> --- a/xen/common/domain.c
> +++ b/xen/common/domain.c
> @@ -1601,7 +1601,7 @@ int map_guest_area(struct vcpu *v, paddr_t gaddr,
> unsigned int size,
> unmap:
> if ( pg )
> {
> - unmap_domain_page_global(map);
> + unmap_domain_page_global((void *)((unsigned long)map & PAGE_MASK));
> put_page_and_type(pg);
> }
>
> @@ -1634,7 +1634,7 @@ void unmap_guest_area(struct vcpu *v, struct guest_area
> *area)
>
> if ( pg )
> {
> - unmap_domain_page_global(map);
> + unmap_domain_page_global((void *)((unsigned long)map & PAGE_MASK));
> put_page_and_type(pg);
> }
> }
On v1 in a reply to Julien you talk of "limiting misuse" by not relaxing
expecations in Arm's backing code, but I wonder what kind of misuse you
think about. Aiui there's no strong need to insist on page aligned input,
and relaxing things there may simplify code elsewhere as well.
Jan
|
