[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH v6 2/7] x86/hvm: address violations of MISRA C:2012 Rule 7.2
- To: Simone Ballarin <simone.ballarin@xxxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Thu, 28 Sep 2023 14:01:01 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6zyyKID/KslGTjHmp0B6uVL1Gi7ynLQi6C0qkbW50DQ=; b=VrO0GeG6qaKR2dRHNVZJk9eLtzD0aOZMByn21ma5OtoSJud3NhDXHhcWjhWzlDBh1r7whdYAazDdV5fw+XQcIJuKgocrYnNdrXpHAauR8v63m77RbcQOMNUWcyOwER6QnTjkzQBEqBYW6oIfVV7XSh9pc0aiMp1ykIxHWzlu08czRgBOEA7UIfBq1zNMcKaRsmdV8rlVVJ72VApV+WvJGmhVmNn+y7mUI/EgKJQ8ddP3RjzYl78XnsYVq5OV5ruKfCkUJRugFcieJqFV+ZP4w4tXY1EjDbzZyM3ArlJFFGO+5hzpRXX80m2MY8cbLSgHnTxVPC2vVa/O3OV6eRabFA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HGW4DafNN8JIXKrP2szhRg4u1q8rUhUiTG1teNPh/zMD/VMfmfMpBOr/gqMwxAaVh3ob6KHRAW97XvQCxhlNkuu1pSRg8TyAnevIGmypJD4cuihlK4J9NDoJVo35s2O/rb2nce3QXmK2sNLTwjmK10LTH2HWcdDk8XviteWu2pGN4rjYxvRkq0CxyZW2drjLNgDDTj+rrV3ESHoo2kl+cTLqlI4aU6lp+hSHwEFJ0eJ561HOes8rYEflXwZ2jv0vrskAKbfdwGpgvPi+9XCTHvtzP1IPwSTu32RBpnuFYoCDoJZBLUpdmMjkm0/oNNYDxS++pVYJmNmQUo+4XZfNMw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: consulting@xxxxxxxxxxx, sstabellini@xxxxxxxxxx, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Gianluca Luparini <gianluca.luparini@xxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Thu, 28 Sep 2023 12:01:15 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 28.09.2023 13:11, Simone Ballarin wrote:
> On 13/09/23 11:44, Jan Beulich wrote:
>> On 12.09.2023 17:38, Simone Ballarin wrote:
>>> The xen sources contains violations of MISRA C:2012 Rule 7.2 whose
>>> headline states:
>>> "A 'u' or 'U' suffix shall be applied to all integer constants
>>> that are represented in an unsigned type".
>>>
>>> Add the 'U' suffix to integers literals with unsigned type.
>>>
>>> For the sake of uniformity, the following change is made:
>>> - add 'U' suffixes to 'mask16' in 'stdvga.c'
>>>
>>> Signed-off-by: Simone Ballarin <simone.ballarin@xxxxxxxxxxx>
>>> Signed-off-by: Gianluca Luparini <gianluca.luparini@xxxxxxxxxxx>
>>
>> Comparing with v5 - are the two tags in the correct order? And is there
>> a From: Gianluca missing now? Apart from that I'm now okay with the
>> changes presented here.
>
> The commit is new and it has been obtained splitting a previous commit
> made by Luparini. Currently Luparini is not working on that, for this
> reason I'm the author of the new commit.
>
> I thought that the first signed-off tag should be the commit author,
> this is the reason why I've changed the order.
If this patch is a the result of splitting an earlier larger one, then
the question still is who made the (initial part of the) changes that
are now in here. If it was all you, then I don't see why there's a 2nd
SoB. If part came from Gianluca's earlier work, then imo the first SoB
still ought to be his.
Jan
|
