[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH v6 2/7] x86/hvm: address violations of MISRA C:2012 Rule 7.2
- To: Simone Ballarin <simone.ballarin@xxxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Wed, 13 Sep 2023 11:44:14 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pd8omn2nlGd4LCA94hHWhUvSK6NlXCdNeFEp/RZKfDU=; b=XDZMMmL49+UworczhTbzpNanyNOFxqxwZxd4FZZ2fN13PeYtYAS9C6rt21fzaCSXuE0eM/iFsh6f0hK9qbUTZXaKV6CSvV8yijL05WNh4rScePj4TcNSaYSALn3MI1r0LFGquX7gR6pcDxTYnOGKhm66WkqSVZAuOh7enaW8I/COx8DvG7esX4ZVlHuEN4xsOZ02aBQXNjvQOz+iWX31qK4PjS2uo8mpy4YjPcwWiN0+6SsoyZI+yMxOd2E2cNJJn00H6jL64/tu4NuXb7DJoP0b+XN78ISgtgjNPnrMhIwsg+ts0giCq5cHhegI8CVYWYzCqEqIt/jmHBXdJN9zIw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EOSq9z0lp8E0m7bclYRvtoi1sH56F5mX/PZdgo2a5TRryvXnX21bdsN9lun8JWZX9U1OJRj0++XZ3hWiZP+r6Az/7tOc9TE7NnyKdx27vM+DoSNIS0pEqbI3xC1IwVU5XOs/5naBEioRM4JHcOpCF7pQbfVYj0f8+jv6DxKXpn/kmzhYL79ve/wwnua1fdjYLOzHrc0+6hZP7yrgsN/EfrcplEUGQJLptJa3Hf/HoihUGUyqd8gSooDGtthIFkfedK9MYO/7JbZ49EriQe9HmZpLJoGJuMnt627vZZ138a8IL2DCvuUTgU4r+i9lHwgYVzyJqC57zo8+UpUAqjsydQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: consulting@xxxxxxxxxxx, sstabellini@xxxxxxxxxx, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Gianluca Luparini <gianluca.luparini@xxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Wed, 13 Sep 2023 09:44:22 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 12.09.2023 17:38, Simone Ballarin wrote:
> The xen sources contains violations of MISRA C:2012 Rule 7.2 whose
> headline states:
> "A 'u' or 'U' suffix shall be applied to all integer constants
> that are represented in an unsigned type".
>
> Add the 'U' suffix to integers literals with unsigned type.
>
> For the sake of uniformity, the following change is made:
> - add 'U' suffixes to 'mask16' in 'stdvga.c'
>
> Signed-off-by: Simone Ballarin <simone.ballarin@xxxxxxxxxxx>
> Signed-off-by: Gianluca Luparini <gianluca.luparini@xxxxxxxxxxx>
Comparing with v5 - are the two tags in the correct order? And is there
a From: Gianluca missing now? Apart from that I'm now okay with the
changes presented here.
Jan
|