[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] xsm: removing inclusion of byteorder.h



On Wed, Aug 16, 2023 at 3:05 PM Daniel P. Smith
<dpsmith@xxxxxxxxxxxxxxxxxxxx> wrote:
>
> This is to complement patch 'common: move Linux-inherited fixed width type
> decls to common header' by removing the unnecessary include of
> 'asm/byteorder.h'. In the process of removing these includes, the ordering was
> corrected to comply with current coding style.
>
> Signed-off-by: Daniel P. Smith <dpsmith@xxxxxxxxxxxxxxxxxxxx>
> ---
>  xen/xsm/flask/ss/avtab.c       | 3 +--
>  xen/xsm/flask/ss/conditional.c | 9 ++++-----
>  xen/xsm/flask/ss/ebitmap.c     | 8 ++++----
>  xen/xsm/flask/ss/policydb.c    | 9 ++++-----
>  4 files changed, 13 insertions(+), 16 deletions(-)

These four files all call le32_to_cpu(), so AFAICT, you are trading an
explicit dependency for an implicit one.  Is that what you want?

Regards,
Jason



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.