[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [PATCH v2 1/4] x86/microcode: Remove Intel's family check on early_microcode_init()
On Mon, Jun 12, 2023 at 06:31:13PM +0100, Andrew Cooper wrote: > On 12/06/2023 4:16 pm, Jan Beulich wrote: > > There are many places where we make such connections / assumptions without > > long comments. I'd be okay with a brief one, but I'm not convinced we need > > one at all. > > I agree. I don't think we need a comment here. > > I'd also tweak the commit message to say "All 64bit-capable Intel CPUs > are supported as far as microcode loading goes" or similar. It's subtly > different IMO. > > The Intel microcode driver already relies on 64bit-ness to exclude and > early case (on 32bit CPUs only) which lack Platform Flags. > > I'm happy to fix both of these up on commit. > > ~Andrew Sure, I don't have a strong preference either way. I'll remove that for the new series. Alejandro
|
![]() |
Lists.xenproject.org is hosted with RackSpace, monitoring our |