[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 1/4] x86/microcode: Remove Intel's family check on early_microcode_init()
- To: Alejandro Vallejo <alejandro.vallejo@xxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Mon, 12 Jun 2023 17:16:44 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bv7ZpBsk1pTEgEsGgHquvGXDbPOkVmPK+PFe59RXfDo=; b=cmHksrhuXQrhz6gO6YfuSC496S7Lksd09/SADkHYeJLmJfmsA8k7UHE5LnePgACqBuJKueOnbfZ60BEpDje2nQuveGqBl4Cky+fdblfS4dz1FDu1pT5WnA/oz0edwKAlGhxlcjbHSKKvWyY8Ip2/fJaQIshxlJVUDeHnjLTKtMtDTfDM6jYr2iWWmk6Sj4te8soPp1dhZvNSetA2ddsvtmpLQccJcuFfPdOJiCORM5vR58/o/oWGaTm/pJp5qEyS+345O9XuD3hFz121wO78+xYIl/X5p8b6tssqdJTurwtossqBbLaLDPjGzOO1mpR9e7syZm9cmn0Orn1MZjZ1Gg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CBDuCMH9CmYDvpaNlW4Mw190SH5vpb4ax0yFqCtPQ0b6pYRtoGWHg7PQqAj1tcYZsPOQ/WR1qKZX2SZI456Vv0RnTb1iALmFY5GvKN+L3d5kM2x8Zrrjx9FAikPcdoNrHTyZLlrTqlYAcwHunQAC1MqEfdXLq3hhbnBY6+tKOx3B97lb4xbTMVQDMGhNbHGY6vlx/eDzSFGaIvvfUwHCzFq6cuu3VdWr00V1qBAMbvU5GAL/Yl0Yhawx7UA1jfcsg9RP7P6fVuWm7rNxPjEPwTiH6mINfMLmJo/Bo7wI1gdWyfFgx/Fg8jFaIMGv0jmJoGkUapORtje4EWSGB0kJKQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Mon, 12 Jun 2023 15:16:55 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 05.06.2023 19:08, Alejandro Vallejo wrote:
> --- a/xen/arch/x86/cpu/microcode/core.c
> +++ b/xen/arch/x86/cpu/microcode/core.c
> @@ -854,8 +854,14 @@ int __init early_microcode_init(unsigned long
> *module_map,
> break;
>
> case X86_VENDOR_INTEL:
> - if ( c->x86 >= 6 )
> - ucode_ops = intel_ucode_ops;
> + /*
> + * Intel introduced microcode loading with family 6. Because we
> + * don't support compiling Xen for 32bit machines we're guaranteed
> + * that at this point we're either in family 15 (Pentium 4) or 6
> + * (everything since then), so microcode facilities are always
> + * present.
> + */
> + ucode_ops = intel_ucode_ops;
> break;
> }
There are many places where we make such connections / assumptions without
long comments. I'd be okay with a brief one, but I'm not convinced we need
one at all.
Jan
|
