Re: [PATCH v1 2/3] xentrace: remove return value from monitor_tbufs

[George Dunlap <george.dunlap@xxxxxxxxx>]

On Fri, May 26, 2023 at 8:29 AM Olaf Hering <olaf@xxxxxxxxx> wrote:

The function always returns zero.

I think a better argument (which I propose to replace the content of the commit message) would be something like this:

---

The program is structured so that fatal errors cause exit() to be called directly, rather than being passed up the stack; returning a value here may mislead people into believing otherwise.

---

With that change:

Reviewed-by: George Dunlap <george.dunlap@xxxxxxxxx>

If that sounds OK to you I'll modify it on check-in.

 -George