[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH v1 2/3] xentrace: remove return value from monitor_tbufs


  • To: xen-devel@xxxxxxxxxxxxxxxxxxxx
  • From: Olaf Hering <olaf@xxxxxxxxx>
  • Date: Fri, 26 May 2023 09:29:15 +0200
  • Arc-authentication-results: i=1; strato.com; arc=none; dkim=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; t=1685086173; s=strato-dkim-0002; d=strato.com; h=References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Cc:Date: From:Subject:Sender; bh=WpoeBuGWahQjx/3EeADqCoRxafSHjWOb2yRv/RTe6Uo=; b=CNJ3dvKAoMGNLpiIxAvXaQHTpNikEjPtwMG9JacnTIOf/iKgd7MdCIEQ1RSANa5M1y E8zfs63wZJKlHIhW9WLT5BKZTX+jl34aA4Pvx2AUztlO6y+0YdvBFTztLJOMm6/AQ2Cq 5ZReVSJHjmKabF/skGUxoTW7TjaAdiDkuc2Gzq7iybW8yP09N4Hw5OyMRFXNxWqhn5Lp ILfnRosz5OCSKTLCPjsA7e8nLdOvhwQAbyG9ap/uwFiQfMm2tCz4zyiVVwZc9a90fyOH hYQ5CliZGoyip+WCXl8gLRXzMsSRnwXs5ZseL55Bbv1viJWAvDq/Hm9vXmBCBjfP7Mx4 oL2g==
  • Arc-seal: i=1; a=rsa-sha256; t=1685086173; cv=none; d=strato.com; s=strato-dkim-0002; b=l1i/SpN7IoXyLCxtKbRcE8qxemJPzqzhZiiabaWtd8WLn+qgtkSOJOsO07vC8PyCrH 0tU5ArybFAiqgIrW3AyIPnYeZBX/ilDR+HtbCuUcphuFrpuYhCsD9TCQf9pmrNHdPyzO O4KMPY6v4oJAICXF853449xMDiyRgaQLIvC3Mgl6M7HI2fwAdySVQj+OOkcgEKdUcdLi TkPpyp1D+8CiENDUdERdN5tYYTp/kmxico2RCNYFfxKWpPgp6f0iaibJbH2+ZW36+mm9 wa0TtLEe07LgMAHTZjySnonJU9xwv9RCcGXsL/MFskehM0QxxUTSfITeVNQwxSh72DbG VK9w==
  • Cc: George Dunlap <george.dunlap@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>
  • Delivery-date: Fri, 26 May 2023 07:29:43 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

The function always returns zero.

Signed-off-by: Olaf Hering <olaf@xxxxxxxxx>
---
 tools/xentrace/xentrace.c | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/tools/xentrace/xentrace.c b/tools/xentrace/xentrace.c
index b81abe8a51..a073cab26d 100644
--- a/tools/xentrace/xentrace.c
+++ b/tools/xentrace/xentrace.c
@@ -668,7 +668,7 @@ static void wait_for_event_or_timeout(unsigned long 
milliseconds)
  * monitor_tbufs - monitor the contents of tbufs and output to a file
  * @logfile:       the FILE * representing the file to log to
  */
-static int monitor_tbufs(void)
+static void monitor_tbufs(void)
 {
     int i;
 
@@ -795,8 +795,6 @@ static int monitor_tbufs(void)
     free(data);
     /* don't need to munmap - cleanup is automatic */
     close(outfd);
-
-    return 0;
 }
 
 
@@ -1164,7 +1162,6 @@ static void parse_args(int argc, char **argv)
 
 int main(int argc, char **argv)
 {
-    int ret;
     struct sigaction act;
 
     opts.outfile = 0;
@@ -1226,9 +1223,9 @@ int main(int argc, char **argv)
     sigaction(SIGINT,  &act, NULL);
     sigaction(SIGALRM, &act, NULL);
 
-    ret = monitor_tbufs();
+    monitor_tbufs();
 
-    return ret;
+    return 0;
 }
 
 /*



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.