[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [XEN PATCH 08/15] build: use $(filechk, ) for all compat/.xlat/%.lst


  • To: Anthony PERARD <anthony.perard@xxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Thu, 25 May 2023 14:04:00 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Dwp7XA7BkKPFTSzfgcedWNSXYZUcivQb56k+3yfThZA=; b=jFOyQzmuOxDZ/E9w7FVQdfb2tvlOthmHRJn20KTk88U7l+VLZ1zYsl/FBmVqBW1azSiuU47YKpelHrZ4V8GSSbkPFonQeWVWwCWvxhJpBDQ5YpTtC6oNQh/PDhaB48hCsI+Z0UOF/45h2ZZC+9ukGAEGcCuULShvFzFvzsB+pb2RKF3a6zVkWUo06LELYye6NXuCv9tmGTqoYfXFLV9mwDN1k+iKivmAQx9NLayQYTA8ilRrQBH51+e56wKVWIBz8VbuaRbAcd8HfwtkT5Tsqt8eJ8mR31T66SE9ZH+dAzj5gsYdMiUqBibKyaS8svarWRbWWSjeZiKCJbf0nX1UOw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ez36WMowM3z4pb39px9vodN1uefUCLSbZd+1KQycbvyQAo3zPc3LEvKPRxRoe+Y/yH2sKHK5R+O4I4n4zMrwdLJCU5Lik1tfg+355+NErdAZAG82C4RHOp2hOvAql3GdMoVM7sUexY8VYCCJibP5Rbrc41LhnhT79IxXQBlYcR2XaY042P8FoxDFfFDwYLV6q6Z2b5q8uawvjRj9Y8dyplWC33AFzxuJeJJNcRawRAbEgZBIROiEgQqynX0a9cimQ8Y88j6rd0XLrVROBbg8L7jn7XmkngTlA2r61dFYNEIwxsSW3f7FIYi0QTlU+RmQZWfr5ZRBGD113I9oaNrdmw==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Thu, 25 May 2023 12:04:12 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 23.05.2023 18:38, Anthony PERARD wrote:
> Make use of filechk mean that we don't have to use

I think you mean "Making use of filechk means ...", or else it reads as
if you're changing how filechk behaves. (I'd again be happy to adjust
while committing, provided you agree; here it looks pretty clear that
there is no dependency on earlier patches, and there's also no need to
wait for further acks.)

> $(move-if-changed,). It also mean that will have sometime "UPD .." in
> the build output when the target changed, rather than having "GEN ..."
> all the time when "xlat.lst" happen to have a more recent modification
> timestamp.
> 
> While there, replace `grep -v` by `sed '//d'` to avoid an extra
> fork and pipe when building.
> 
> Signed-off-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>

Acked-by: Jan Beulich <jbeulich@xxxxxxxx>

Jan



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.