[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH 08/15] build: use $(filechk, ) for all compat/.xlat/%.lst
- To: Anthony PERARD <anthony.perard@xxxxxxxxxx>
- From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
- Date: Wed, 24 May 2023 08:13:23 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jE+3IFOIGu7z7+DJWr7+RUgt8xxDUyDgAXMrkJnU1XY=; b=jLyvrHLYIZxRlsGxE3ho5bqmktF5EgUe3nxICX0bzYAL8b/lpqWV+Lydv4aIL5klwpMEMUcd3oOLDF4yo98AHD+hwdrjRkVi3gisQQXQppez0JPczNe6r16KCIWAz591/pR3x95RjncsYSe+9iJAxCS5ndHYnyn+prco8hzUhqhhDpBikmARSvr5naxUk+l8w0p/HM8qYR0DtHMmsVu1g6FV99JtX31Q3kiUg4+U5yMWG6AS+bGXOXWLOPbRWM9sobSU/T+R8vvyJpjJ3RlFOZrztiUt+Fw/RdEMZFocE4FCtjf93e2iyxvJOaZdKJYhJyyo0EQSt5Rz+oPnvnq39A==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=N4GiBu3HkUu6m//6PZfP7FXbMp3HJkvMa29DW1tJv2rsemKu/Jq4U3N0bX3AE7PPFMj1bK5XMZrsCwzViJixGTf8qePhAZ8a1BLGO7+wi5o7iZOQnjCIYX3jGYoVGlJZvGLCdoJLopFiUTwhoqJ2zm5H5fxvQUwyemKMmS0mOejpmGm4kiUZ2oHarnNmfT4FDqwJsGCDdkX51bWQFMDcmC9fe51AIMgL/Ke5+CLZACUaArZ9F6Bv2mWmd3VBw330to1/m+fV1/6379mjVomsjc/99WKRsc6WDbcDtzlcQmVdMonTqZuJF/ltttRj/cd4GkvUvh1tLnLssZJjaCb0pw==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Wed, 24 May 2023 08:13:50 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHZjZUbjxSqGdWpCESp84pzrS3Y8a9pE/8A
- Thread-topic: [XEN PATCH 08/15] build: use $(filechk, ) for all compat/.xlat/%.lst
> On 23 May 2023, at 17:38, Anthony PERARD <anthony.perard@xxxxxxxxxx> wrote:
>
> Make use of filechk mean that we don't have to use
> $(move-if-changed,). It also mean that will have sometime "UPD .." in
> the build output when the target changed, rather than having "GEN ..."
> all the time when "xlat.lst" happen to have a more recent modification
> timestamp.
>
> While there, replace `grep -v` by `sed '//d'` to avoid an extra
> fork and pipe when building.
>
> Signed-off-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>
> ---
Seems good to me!
Reviewed-by: Luca Fancellu <luca.fancellu@xxxxxxx>
Tested-by: Luca Fancellu <luca.fancellu@xxxxxxx>
|