[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [XEN][PATCH v6 11/19] xen/iommu: Introduce iommu_remove_dt_device()


  • To: Vikram Garhwal <vikram.garhwal@xxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Wed, 3 May 2023 09:56:11 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=V1x8YyTWyQBNdIxAs9f3haq8niI/qNnULSndmW7mmjQ=; b=epASxsusJnEMjGQas782OyL9/0RPLQ9GlFWOlkPyLznnwq3laM+xeuyvGEK0PUrsjfev/Cl+/vGnFSgn4AZKC5ESKeUfcKFP82tvlMGP4EuF4Nb90Zij6Fug1kE0f/tdjwvAsbNoOLoIzfNsqSfOV5naGLUVHvHGDqETPHuZr6jgijxXuMu7zbZgz2LoNghIs9gHbeica6Ehrsd5D1he0JIger0b7NLI7DDkODWwVH++pY6iWdL7aMyA4UNarqOlqkchQy/ha0HBfQDd3Hn7q374Qzteh5Vb51JKQ1GN0N6NoDsKMcG/GbbKdfEBJZ73B5rNdSl0IR7oPhSGk29MNw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UiJ0wOBbjB0Qz7Au7ACpQDJLnP+cjf2b8roK6Gs4RbM1l+/nWn5veVz1WK0g4Ie5ka5kfSr0MFyITsTNsdU2c5Ucv2Fi8EEslpVhOQ+F/GkkTM2lJDJoR0j09RWxleMT7VAg5xkeuiLAiHCbMPZf9XeYpnW9dkARqj1T4wffTXofcEulugILt/J5vf3OQQsjTyI/V7wzHcSLITM5ehsbLSGYVt8fzE21fIYWwLn9cZmlH1nZW5OfLBF85gL8LdLAGO4E4pHQB5nYt/8LcVE6QkHCJ0N2cJ96jp1/q/rqNGUSlM2sEGpaHzcTTND8cqWBWRqJZg9uBKJceLoxFxAZUg==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: sstabellini@xxxxxxxxxx, michal.orzel@xxxxxxx, Julien Grall <julien@xxxxxxx>, Paul Durrant <paul@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Wed, 03 May 2023 07:56:24 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 03.05.2023 01:36, Vikram Garhwal wrote:
> --- a/xen/include/xen/iommu.h
> +++ b/xen/include/xen/iommu.h
> @@ -219,6 +219,8 @@ int iommu_deassign_dt_device(struct domain *d, struct 
> dt_device_node *dev);
>  int iommu_dt_domain_init(struct domain *d);
>  int iommu_release_dt_devices(struct domain *d);
>  
> +int iommu_remove_dt_device(struct dt_device_node *np);
> +
>  /*
>   * Helper to add master device to the IOMMU using generic IOMMU DT bindings.
>   *

Nit: I'd consider it more logical if this declaration came after
iommu_add_dt_device()'s. With that adjustment:
Acked-by: Jan Beulich <jbeulich@xxxxxxxx>

Jan



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.