[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN][PATCH v6 09/19] xen/iommu: Move spin_lock from iommu_dt_device_is_assigned to caller
- To: Vikram Garhwal <vikram.garhwal@xxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Wed, 3 May 2023 09:53:43 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=e9CbK7nt9CXb0fo98FUzYPyx8qOlbbc9IREixlGl91A=; b=Hq9ADPT4pF0QUafHQNiQWBKGf33xjbLJ7IIifg4w9z+ZzVeAjUHFX+zilK7tjsSZZ5li1Gj1/l93l9QCVzVYPELxQpjP3kI+FzAJx6GFjbWvnS7RYXIuEtHnAosJGIdoDwW9Wx6P0/Lwx9/IPzpYt3RXwk5fk457lA2i3Nra6dnFgWxBJ/xxBFoIywn/ydgPqh6t2TyrZ4O5Mh/GgPE4YmgIaT8ozQDAC5UaLsAxRnL3GzLzD8MhY+yijhRc9TCZxEtFNat1dwksxcoVzd/kq1r+4yX3SK3WsCncRcbG9hCopwvpCmb9fqw1OnsDaMyemdBg3KVfpeALxKPLvmIQvQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YDh4CXiHVE0BJZWqTtssqSY/PAUkMuWOkg3SLgOyFBzEZeDOS2v5Xu1WmtN33BFQ+tEC637oKgXenG6gzTRSUiA+A4qKC3U1kR1WLf9+ikIPBjYRrdIFD+G4OIB8oUWdH3Uz990MSM3fs0hU/ZE1+wzoTBKojCPYZRkh4fqS7QFpy/1VWzeRJW9dn8frMoRp+49UtWFebHpsWFLIDdHST6eVK3Vjnk+QcGH+QSXUCkmYm0xHBIyNeLI6ptcSTocsps4X3F2BhvWja/AlZ1mLTohzyxzbbfXGBtN537Rzz/fAom0kyyECPUYNk95XCQvd6xNBd9/Y8aKxoWDMuQeTIQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: sstabellini@xxxxxxxxxx, michal.orzel@xxxxxxx, Julien Grall <julien@xxxxxxx>, Paul Durrant <paul@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Wed, 03 May 2023 07:54:01 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 03.05.2023 01:36, Vikram Garhwal wrote:
> --- a/xen/include/xen/iommu.h
> +++ b/xen/include/xen/iommu.h
> @@ -214,6 +214,7 @@ struct msi_msg;
> #include <xen/device_tree.h>
>
> int iommu_assign_dt_device(struct domain *d, struct dt_device_node *dev);
> +bool_t iommu_dt_device_is_assigned_locked(const struct dt_device_node *dev);
Hmm, exposing a function globally which, first and foremost because of
requiring the caller to hold the correct lock(s), is pretty much
internal, doesn't look very nice to me. Can this perhaps be put in a
private header, such that it gets only limited visibility?
Jan
|
