[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN v5 02/10] xen/arm: Typecast the DT values into paddr_t
- To: Julien Grall <julien@xxxxxxx>, Ayan Kumar Halder <ayan.kumar.halder@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Michal Orzel <michal.orzel@xxxxxxx>
- Date: Wed, 19 Apr 2023 15:39:28 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=xen.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BI+HV4k8xOmnaLaaH27Lz93CeUO7TuvqADEcZE2eBPU=; b=EwiccXcPrF6Vhp8G7JdGQ+LRUa6m0NV+dY60JqzB+uOTaS+eOrLs9f1E1E8FPHkIRCHxiGf1Rg8OaAmZ8m75tbZqoLvZ2vITClplv8KLDfKfauTnb3eiP96G6ZTf85fHoV7K7kbeggrD4Tv6NPf7ESd90vAg+PoIKxF7BqeiNWL0sT8XlE4HdHpE5RIyZBPaVmFjtXkDVI8yBwzPES1CA/YKlElZGQ5u4TedVxKE59MB8SVN/BLg8gAG2Ao7ayf8bNTS/UO2f8/qUx+4C1zCVrIqsiJESsfEEAioRi5WZTCFqKOVfXo/ajhG1DGqxtUSPwdQGBE/6PlYx+RLTGizJg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ivwj+/fLHsAAMYalgfNCWwDE0p8dNlTfbmaqNLTXqPS8Ect4tvXfRvrYzOhHjHpJJ6X7rE9Wvz2cF2wVObCIV3g9fpw+VVqoadAGOI2NYN8pGyW06c1Yb8mTekHRdEUjFtn8THgZZzI1JMotj9/DPCix3ptjbWOCK5jVlXmXonnIoUgk9XaJKSkxnRgNydRbX7d10ZWlEaArZNLWzWCLof4xfYxWQXvHebtwlWEhpiG707EqffSConQTO84LDMzMCnNmdhaiy4DblRmNfcwcutfTHl7Xv4wzXVQKXbWDmx9rdTKG7xkkiOSMoZ7P80g6yGlKGzbZ8DDks3JniuXV9g==
- Cc: <sstabellini@xxxxxxxxxx>, <stefano.stabellini@xxxxxxx>, <Volodymyr_Babchuk@xxxxxxxx>, <bertrand.marquis@xxxxxxx>, <andrew.cooper3@xxxxxxxxxx>, <george.dunlap@xxxxxxxxxx>, <jbeulich@xxxxxxxx>, <wl@xxxxxxx>, <rahul.singh@xxxxxxx>
- Delivery-date: Wed, 19 Apr 2023 13:39:44 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
Hi Julien,
On 19/04/2023 15:26, Julien Grall wrote:
>
>
> Hi,
>
>>> diff --git a/xen/include/xen/libfdt/libfdt-xen.h
>>> b/xen/include/xen/libfdt/libfdt-xen.h
>>> new file mode 100644
>>> index 0000000000..3296a368a6
>>> --- /dev/null
>>> +++ b/xen/include/xen/libfdt/libfdt-xen.h
>>> @@ -0,0 +1,55 @@
>>> +/*
>>> + * SPDX-License-Identifier: GPL-2.0-only
>> Our CODING_STYLE says:
>> New files should start with a single-line SPDX comment, ..., e.g.
>> /* SPDX-License-Identifier: GPL-2.0 */
>>
>> For me it would be perfectly fine to do as you did but it is not what our
>> docs state
>> (i.e. single-line comment). It might be that we need to modify CODING_STYLE
>> instead.
>
> From my reading of https://spdx.dev/ids/#how, what you suggest would
> not be a valid SPDX-License-Idenfier as everything in needs to be in
> *one* (including the begin/end comment).
I said what is written in our CODING_STYLE and what we did already for lots of
files, i.e. having 2 comments:
/* SPDX-License-Identifier: GPL-2.0 */
/*
* ...
*/
In the link you provided, the "*one line*" requirement refers only to SPDX
short form identifier
which does not contain any other information like author, description, etc..
~Michal
|
