Re: [XEN v5 02/10] xen/arm: Typecast the DT values into paddr_t

[Julien Grall <julien@xxxxxxx>]

Hi,

> > diff --git a/xen/include/xen/libfdt/libfdt-xen.h 
> > b/xen/include/xen/libfdt/libfdt-xen.h
> > new file mode 100644
> > index 0000000000..3296a368a6
> > --- /dev/null
> > +++ b/xen/include/xen/libfdt/libfdt-xen.h
> > @@ -0,0 +1,55 @@
> > +/*
> > + * SPDX-License-Identifier: GPL-2.0-only
> Our CODING_STYLE says:
> New files should start with a single-line SPDX comment, ..., e.g.
> /* SPDX-License-Identifier: GPL-2.0 */
>
> For me it would be perfectly fine to do as you did but it is not what our docs 
> state
> (i.e. single-line comment). It might be that we need to modify CODING_STYLE 
> instead.
From my reading of https://spdx.dev/ids/#how, what you suggest would 
not be a valid SPDX-License-Idenfier as everything in needs to be in 
*one* (including the begin/end comment).
Cheers,

--
Julien Grall