[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] x86/PV32: restore PAE-extended-CR3 logic
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Wed, 5 Apr 2023 11:40:30 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=glMDDIPA9Olrwj9DPq4D9sJNv7NzFuBiUuVcNTR6e80=; b=APKEV0hloO0/ehkM0yydxWyZdBS+QvvdnL6iHYP8vXWku+zvdchmif1zYz99lMIsiDAXSlECG1fA5FjTIxkpGO8vQaVOjj31r3CeF4SD4DnnQAyx5FD1PxsHzF8K/HBuX4FT/+oY0TP2Tr4osTutSumrYRtDQpEJLw7LBTFF+yg2uO0YoHcudW7jxuc1PcH9+VGybBVVe+PoXDfYG15mWSjr+f0TMtMHZIk25aeP3ClflNplHctoTAgUqiHMpRCopYQmy0rhWBn5Y7mUVZhO+EbgFu3qYd+4D9noJQMSysuCqw7zvENDsgsxuXvfYFh+2ix+G2+fb7fVsH4RBEqaMA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nilq3Neu6MV/8GAvmrJwQYMu+/2UeiiSQi3Daacq+/5pk1yK9xekFlIkzXbZTuzpjWm4ohTrCJgwqBRONqpvwj2lmF3xS8+x7oIp0fFGDadxkjkAmMpsLBX6DuqjeYLJeCq7sZbRDqeZIfqhN2yrpHqOXaizo3TGITM/xeRxuEFfi5+Em4lEp6aS6cDY9J/zbhnK/RxLbt6f2z/imrmeuVRPNSFUBufFDI2UMfFjSjej1iheHKH0QpZV3ATzza69a0g9NuCN9olfckYMfWQAaSc1MX3xl43DYL2NWOSUF12CI8xfp4oDoaCLDlzAb5Bd9drgOP4uZhfw2UTryLCwpA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Wed, 05 Apr 2023 09:41:07 +0000
- Ironport-data: A9a23:H+DvbKLWOGC0tkDYFE+R95QlxSXFcZb7ZxGr2PjKsXjdYENS12dUy 2oYWWrQb/iDNzb9eNsibo6yoUoBuZbQzd9qSgFlqX01Q3x08seUXt7xwmUcnc+xBpaaEB84t ZV2hv3odp1coqr0/0/1WlTZhSAgk/rOHvykU7Ss1hlZHWdMUD0mhQ9oh9k3i4tphcnRKw6Ws Jb5rta31GWNglaYCUpJrfPTwP9TlK6q4mhA4gRjPakjUGL2zBH5MrpOfcldEFOgKmVkNrbSb /rOyri/4lTY838FYj9yuu+mGqGiaue60Tmm0hK6aYD76vRxjnVaPpIAHOgdcS9qZwChxLid/ jnvWauYEm/FNoWU8AgUvoIx/ytWZcWq85efSZSzXFD6I+QrvBIAzt03ZHzaM7H09c5lCEBN0 dwoBgkLSR6Km/CuzOuJVNdj05FLwMnDZOvzu1lG5BSAV7MKZM6GRK/Ho9hFwD03m8ZCW+7EY NYUYiZuaxKGZABTPlAQC9Q1m+LAanvXKmUE7g7K4/dmpTGMlWSd05C0WDbRUsaNSshP2F6Ru 0rN/njjAwFcP9uaodaA2iv02L+WzH+qB+r+EpWi5r1U2QK86FAdCVoMWlWXsOWEkESXDoc3x 0s8v3BGQbIJ3E6hQ8T5Xha4iGWZpRNaUN1Ve8Uq5QfIxqfK7gKxAmkfUiUHeNEgrNUxRzEhy hmOhdyBLSNrmK2YTzSa7Lj8kN+pES0cLGtHaSpaSwIAuoPnuNtq0UuJSct/GqmoiNGzASv33 z2BsCk5gfMUkNIP0KK4u1vAhlpAu6T0c+L83S2PNkrN0++zTNfNi1CAgbQD0ct9EQ==
- Ironport-hdrordr: A9a23:FhMQ0KvYb5F/RrTRic1Vj8cN7skCM4Mji2hC6mlwRA09TyX4rb HaoB1/73SbtN9/YhEdcK+7SdW9qB/nlKKdgrNhTotKIjOW2ldARbsKheHfKlbbak7DH4BmpM Jdm6MXMqyOMbAT5/yX3OHSeexO/DFJmprEuc7ui05ICSVWQ+VY6QF9YzzrYHGfhmN9dOQE/F 733Ls2m9JkE05nH/hTfUN1O9TrlpnwjZf7ZhxDLwc/gTP+9A+A2frBCh2F2RVbeC9OxLpKyx m5ryXJop+7tu29yFv632vehq4m/+fJ+594HcmRjcpQDCvqhh3AXvUGZ5Sy+Aotpf2p6hIRsP SkmWZZA+1Dr0nJe32zo1/W1xL+3C0I43vvoGXo+kfLkIjCXTcnDMgEuo5DaBve7CMbzatB7J 4=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Wed, Apr 05, 2023 at 11:29:51AM +0200, Jan Beulich wrote:
> On 05.04.2023 10:59, Roger Pau Monné wrote:
> > We should likely move the setting of vm_assist to the domain create
> > hypercall, instead of doing it at vCPU initialization.
>
> Perhaps, the more that setting the assist is limited to vCPU 0 init.
> Which in a way makes sense when considering domain creation, but it
> is odd for the case of vCPU 0 being brought down, reset, and then
> re-initialized; IOW I think arch_set_info_guest() should further
> have constrained the setting by a !d->creation_finished check.
Maybe, but still the right fix IMO would be to move this into
domain_create. We could add the !d->creation_finished check but that
feels more like a bodge than a proper solution.
Restoring the previous check is better than nothing, but it would be
nice if long term we could get rid of the vpcu related conditions.
Thanks, Roger.
|
