[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] x86/PV32: restore PAE-extended-CR3 logic


  • To: Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Wed, 5 Apr 2023 11:29:51 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Z9Rxxk0xnOzGBNILaI2KtYmjf6KxyxKXqSchWhBI7lQ=; b=Ia9TTMdLrEyFi1mh1540MpmP3f+31DecoC2D8apK4Xy6+n8SMqnU1Tc9l+8ZzT8Ca/n5gJkgvBWRZurQV6UVr8UEeAZ/hBOBxVyJKK63eY8c38fjo7Ek02U9pMpLkPghjbroiTE2rbM3b1ENr+tiBWTqaUVtVAPO507RvQlsn7o5AR4fumnYdzIogPaefrOThjY7GxyGjip+mGVieEhc/lyMcFaHwj19NS7TNlw5MTR8wFPlsPq2NdPHeoqxkqAgao40OL3og0kIc2RYK8eaNcIS4FWnVcN6yjB9Cfh6xWI+gjn74hT9mVYszEenF3qia+j8+NOs3uYimbydGnTyOg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fBhg9vijep/v9C+llyabXe18soO62vzduroRAbB8BlMvl+73vmxZwu9ZjJlFcbrrOxs05GcL+bG3wRmliZ/9C1GAOtWjQf32dFVLFbnnkHeGmda09Q0KJDTLi3iEcEwDmNrJYO6VcpGIuY0G6AhC/sRtfAhRP3byN3X76Snlb4sL9uTeJ0WGLd0caOtmpKkcsHoKk44mwnAIg+kVfurlzCyodCfGnhYrVXANSPOREijRIfWlDUvuTW6ZsJh1lm6jK04V9S0MFxtj/qjEcQ8C3NL6EtH0E22f71w+tJ0uIxPagVEYPXd5mle5S9axn48uBGx4Jd/OIgwD4ZP1Fc/lqA==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
  • Delivery-date: Wed, 05 Apr 2023 09:30:09 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 05.04.2023 10:59, Roger Pau Monné wrote:
> We should likely move the setting of vm_assist to the domain create
> hypercall, instead of doing it at vCPU initialization.

Perhaps, the more that setting the assist is limited to vCPU 0 init.
Which in a way makes sense when considering domain creation, but it
is odd for the case of vCPU 0 being brought down, reset, and then
re-initialized; IOW I think arch_set_info_guest() should further
have constrained the setting by a !d->creation_finished check.

Jan



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.