[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] x86/svm: Decouple types in struct nestedsvm
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Mon, 27 Feb 2023 11:44:50 +0000
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qBw3KyrQmvkshusC9L5CMRs+YOmuvKEumuAIUYK7BYA=; b=AZ8aLExKHVpHOYvAU32GeVwGTnYsKrzsnmXKbXDPLe6SyYP6l7Hztfrhrwg5bAzvLIwYQI5IjnfO1jlTKGF2e+38ANGugRl0UG3mKCeOtm7ylGD7co1lEQH3d0zHOuvy1ufocQeZFqWg1bnylb8Z67dVbA6FYon0QYzN87fzDwTn57ScOcQPxbJbAmU09h88HF6BeKEBPBF9IlNO0yXRALUNIcG29GBvTAnAk3mZVBmeJSYNIEV1U6gTOsubzeiqpvQwDgd9xKBKt6xaliUEDj35gXhWVvo+/1ND98UtecCj7boyw300LPszYQHAAXNZBmBfkGq6eXgzMqHAt8Jxbg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VXvhfaRGFwBCSHFQiF9YQK4JCXDS97oxchCpVODSDx4ySOD2yphMvle99HMW4Se2r9W0l8gWnl20eO43SAEw05nYvV6piPGUsOfIo43ZG3jxXx8LCwlVyAyRLNBe3r5SC94gRll7Z6JxXXxLzrvVH1tf+UtikFXmMumm1h4y3AHYseOmdVJifSYmSIooYnTEyQd2hQOtv0sTBeMap5IruALJFqeVYD8p66zOOMQlXGXgGh70R29nEeZkEq7NjrG9hUfMdfAMOycICjH8H/cx3cDijylE6dh1gT8jwXYw0ePIrD9AWROLEjrrF+554BY5StmWo4/YTvS226aHmJnISg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Xenia Ragiadakou <burzalodowa@xxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Mon, 27 Feb 2023 11:45:17 +0000
- Ironport-data: A9a23:RI4K+Kw7MYakmBOt1RB6t+cAxyrEfRIJ4+MujC+fZmUNrF6WrkUDy mMaWTyAPfmJNmSkKtp+YYjl/UgD65XdmIU1TQc/qyAxQypGp/SeCIXCJC8cHc8wwu7rFxs7s ppEOrEsCOhuExcwcz/0auCJQUFUjP3OHfykTrafYEidfCc8IA85kxVvhuUltYBhhNm9Emult Mj75sbSIzdJ4RYtWo4vw//F+UwHUMja4mtC5QRkP68T5TcyqlFOZH4hDfDpR5fHatE88t6SH 47r0Ly/92XFyBYhYvvNfmHTKxBirhb6ZGBiu1IOM0SQqkEqSh8ai87XAME0e0ZP4whlqvgqo Dl7WT5cfi9yVkHEsLx1vxC1iEiSN4UekFPMCSDXXcB+UyQq2pYjqhljJBheAGEWxgp4KWBp0 vMoKCIGVzXd3/vpmoD4etld2+12eaEHPKtH0p1h5RfwKK9/BLrlE+DN79Ie2yosjMdTG/qYf 9AedTdkcBXHZVtIJ0sTD5U92uyvgxETcRUB8A7T+fVxvjiVlVIhuFTuGIO9ltiibMNZhEuH4 EnB+Hz0GEoyP92D0zuVtHmrg4cjmAuqCNpPTezlqpaGhnWLzG9CBxs4cWK1uKGU2wniGMBEM HEtr39GQa8asRbDosPGdx+yrWOAvxUcc8FNCOB84waIooLe/hyLD2wDQjleYfQpscY3QXoh0 Vrht8PkA3ljvaOYTVqZ96yItnWiNC4NN2gAaCQYCwwf7LHeTJobixvOSpNpFv6zh9isQDXom WnU/G45mqkZitMN2+Oj51fbjjmwp5/PCAko+gHQWWHj5QR8DGK4W7GVBZHgxa4oBO6kopOp5 RDoR+D2ADgyMKyw
- Ironport-hdrordr: A9a23:esflJaEV7TzQBXUYpLqE7MeALOsnbusQ8zAXPidKJSC9E/b2qy nKpp8mPHDP5gr5NEtApTnjAtjifZqsz/5ICOAqVN/JMTUO01HYTr2Kg7GSpwHIKmnT8fNcyL clU4UWMqyWMbGit7ee3DWF
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 27/02/2023 11:41 am, Jan Beulich wrote:
> On 27.02.2023 12:35, Andrew Cooper wrote:
>> struct nestedvm uses mostly plain integer types, except for virt_ext_t which
>> is a union wrapping two bitfield names.
>>
>> However, it turns out that this is a write-only variable. Delete it,
>> allowing
>> us to drop the include of vmcb.h
>>
>> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
>> ---
>> CC: Jan Beulich <JBeulich@xxxxxxxx>
>> CC: Xenia Ragiadakou <burzalodowa@xxxxxxxxx>
>>
>> v2:
>> * Delete the variable entirely.
>>
>> This probably means that nested lbr/vmloadsave is broken, but that wouldn't
>> be
>> a surprise at all.
> Well, yes, short of figuring out what's missing this is probably the least
> bad option:
> Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
Thanks.
I'm pretty certain a working version of nested virt won't need this
cached information like this at all. I'm pretty sure it's buggy not to
be referencing the appropriate one of the 3 relevant VMCBs.
~Andrew
|
