[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] x86/svm: Decouple types in struct nestedsvm
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Mon, 27 Feb 2023 12:41:48 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SqyxAaHyjYnZId1R023Dey35QLGxvmBHDMcwCyDHp1c=; b=eKlEA+ro09eywfuztMzH+cCUQ4RWYRCVPpWR2iPmbAxIxK6P4bHoTW7Jz3iz/k2TYUmcQY4uCnwQIntUuHag/NnGSHeKSAQ9s764lzbqEBHl7IHjr7zPQO3FfMYxVKHDiYWsn4IMHwBkcxHb2xMZz07mvSphHjrd715hmrqcHj39p3VFqNUf7M6NI7Ueo/9O2cuku0XqvZRvuutLE28szYElP9QYkFgEBb0gwUgToZnLf1p+4hbxUtvq+9HvoAqIMbEPhqGTvRWKQphxdFoZfap2DAJugGyS38VG2pu58laih1cxVaHacpY4d1x5j8oGqz70CpByKaUI4x+47Qg42g==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PPnC9nF5hQ5i9twhN/481DN1AuXSkx2NpX11NIW44zIKi19Sq3FBPIoh7xZ54oj31Jw2vT/ew37BrtzjkBJP3uoroCqH6XB7ap/jI30X+mCQCyfRAu6nzHSoEbaVtCnWFfnicdOOJVJhTtt1FcO98Je8MZqKq6dQk0NNPs6f0Em5ISTuS/J6Lk0lI7h1hKaeSGV7sCcdRH/8TrPIfmj7eEYaZHmtaUlDpiqjM2gL729jP7lw7BjSH/EjOhlhQW32GiYX/0ngLFpgPS2qNhUJj9ZBK+RP6jX9Fe9WYXxzS9UPI8W19qJBpO26LRuFwfaNmhSlFWehG2w7HEb9ixIJKA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Xenia Ragiadakou <burzalodowa@xxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Mon, 27 Feb 2023 11:42:04 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 27.02.2023 12:35, Andrew Cooper wrote:
> struct nestedvm uses mostly plain integer types, except for virt_ext_t which
> is a union wrapping two bitfield names.
>
> However, it turns out that this is a write-only variable. Delete it, allowing
> us to drop the include of vmcb.h
>
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> ---
> CC: Jan Beulich <JBeulich@xxxxxxxx>
> CC: Xenia Ragiadakou <burzalodowa@xxxxxxxxx>
>
> v2:
> * Delete the variable entirely.
>
> This probably means that nested lbr/vmloadsave is broken, but that wouldn't be
> a surprise at all.
Well, yes, short of figuring out what's missing this is probably the least
bad option:
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
Jan
|
