[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 1/9] x86/svm: remove unused forward declaration of struct vcpu from svm.h
- To: Jan Beulich <jbeulich@xxxxxxxx>, Xenia Ragiadakou <burzalodowa@xxxxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Thu, 23 Feb 2023 10:50:20 +0000
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=M/tXN2Q8taSMsAcMfz02T+xeXvn5gf+arlcTs2lVIKs=; b=bkNysSqFEsuEbGktq8Fys5CTxkSJlcROv/xpQHT7Ij8bYe7emU5mN7A8oeG1BTS/QSs0upNn0b/tkb8eBHiFO/Rrb8IybkN0hOx8xi8NTvKDjMY1RENThB5N98hCOopQ2F/zshytJ2z+H0qc0mSOFiKlWf+01KZEijWDbRewoKZrsYy9HSjjzuWOBr7DFyjCC2YpyU86SK/ub6jg1iCRnKcyI406Wap5b0u7z+zDrpiQYyZQAuxlMItvG9dpB5N09jN1m7IXp2L5A1t4msTtv7sPTB+zSIhS7Ika9uNRaRyrtJDH8q18d3Hd3sFWftYlarSMw4SnQgoXTgobE/bjTg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=m4LEjw001EVVkS7dwbHifxF63iTgQ7gOcI+I+x10TZI4sWpPjBjtGakw6Y3rXfa1/s3xpaLyK3ABa1LiQluxFx3Fo3S2ft5WrLIE9ZDjcWHp8ykPcVVeNuNmLEkanIsWWrpkpSjonpPvcy8oV3bSel4zvCQVCc20aiu/SM7QiCzNMD+d9ECI80UOQoqU9dXRweXSWSw+FXqxBe8IYf8cokVHmxmyt270Rsga5nAtMEdZn959ABHv4hwWzdC6L34vSpOanVqfVJa4wwzC/rBYkUrBKIzCmbPgh1DNJJhL/I+bSVvk3xy4uhygzoLIQrxHkUw8opZjIEYnlOG9lG2rBg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Thu, 23 Feb 2023 10:50:45 +0000
- Ironport-data: A9a23:pZ5px6IZUiJw09sYFE+R6ZQlxSXFcZb7ZxGr2PjKsXjdYENS1mZSy DEZD2+PaKqKYWP9fdp0atm180gDvMXUztAxTAdlqX01Q3x08seUXt7xwmUcnc+xBpaaEB84t ZV2hv3odp1coqr0/0/1WlTZhSAgk/rOHvykU7Ss1hlZHWdMUD0mhQ9oh9k3i4tphcnRKw6Ws Jb5rta31GWNglaYCUpJrfPcwP9TlK6q4mhA5AZlPaojUGL2zBH5MrpOfcldEFOgKmVkNrbSb /rOyri/4lTY838FYj9yuu+mGqGiaue60Tmm0hK6aYD76vRxjnVaPpIAHOgdcS9qZwChxLid/ jnvWauYEm/FNoWU8AgUvoIx/ytWZcWq85efSZSzXFD6I+QrvBIAzt03ZHzaM7H09c5lHnNW5 KI4Mgk/Yy+/2+627LCCSfZj05FLwMnDZOvzu1lG5BSAV7MDfsqGRK/Ho9hFwD03m8ZCW+7EY NYUYiZuaxKGZABTPlAQC9Q1m+LAanvXKmUE7g7K4/RppTSJpOBy+OGF3N79U9qGX8hK2G2fo XrL5T/RCRAGLt2PjzGC9xpAg8eewn6rBdhLRdVU8NZw0EzCxFUxJiEIXEmSoPeD0HCFQdRmf hl8Fi0G6PJaGFaQZtv3UgC8oXWElgUBQNcWGOo/gCmH17DG6gKeCm8bRxZObdUnsIk9QjlC/ kCNt8PkA3poqrL9YWKQ8PKYoC2/PQARLHQefmkUQA0d+d7hrYovyBXVQb5e/LWdi9T0HXT13 GqMpS1n3bEL15ZXjeO84EzNhC+qqt7RVAkp6w7LX2WjqARkeIqiYI/u4l/ehRpdELukopC6l CBss6CjAComVPlhSATlrD0xIYyU
- Ironport-hdrordr: A9a23:nGTKqq6qgJFh83dwqAPXwMbXdLJyesId70hD6qkRc3Bom6mj/P xG88516faZslgssRMb+exoSZPgfZq0z/cci+Qs1NyZLWrbUQWTXeRfxLqn7zr8GzDvss5xvJ 0QF5SW0eeAb2RHsQ==
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 22/02/2023 12:59 pm, Jan Beulich wrote:
> On 22.02.2023 13:00, Xenia Ragiadakou wrote:
>> Remove forward declaration of struct vcpu, that is a leftover since
>> the removal of svm_update_guest_cr()'s declaration from svm.h.
>>
>> Signed-off-by: Xenia Ragiadakou <burzalodowa@xxxxxxxxx>
> Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
>
>> Fixes: b158e72abe30 ("x86/hvm: CFI hardening for hvm_funcs")
> I'm a little puzzled by this (a stray forward decl of a struct isn't
> really a bug imo), but ...
>> ---
>>
>> Changes in v2:
>> - leave the forward declaration of struct cpu_user_regs in place,
>> suggested by Andrew
>> - add a fixes tag based on Andrew's comment
> ... I realize you were asked to add it. (As a minor remark, more
> commonly the Fixes: tag would come ahead of the S-o-b: one, I think.)
I didn't intend my reply to mean "put in a fixes tag". I was just
trying to make an observation. But it doesn't hurt either.
But I do agree that a Fixes tag ought to be ahead of a SoB tag. Where
possible, we put tags in chronological order.
I can fix that on commit.
~Andrew
|
