[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 1/9] x86/svm: remove unused forward declaration of struct vcpu from svm.h
- To: Xenia Ragiadakou <burzalodowa@xxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Wed, 22 Feb 2023 13:59:11 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SDi6Bfcv8Lu2yK3u1S8qbcPR/undBb+oSdjV0dUaHUw=; b=L3NTa959cSzifJxBBRGrkhqv1VPu5Ss3yGI2IeleK+YVvlUWSljN3Ote1BuLlwQQzlWRXJNm6P6EoCBp5p6affuYPlXPmZerzcL6Dpp+Xlrqni6QHVam+4ez60kOkhGDkXG5icPizjdgIkzxMzJr6tIf87mODkPkTN7AJxh7dNk+/6GomHlTSIv0rDK2/LAcwnPEuhOM4bHTnOmr85KsrmXTovOONJcCcGCmTzrR+D1bOYasOR5jx5UEAgCxLKY6sxe7fcMhaavOks2iKW65WVEhTfXV60pF8tfnN8E43c6M/Rz8HRE5YkYHIl+Nq+MPBOBqtudO6Z/Vgz9s8BgsFw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=D5JsBXHElQlS+32LI3jTx78LMzaEYQx5/4VsV1owO5M0RPqzKDO7POVw4FdEKH5RHByYY3vkaJQ4/6oVNiW1V1frmQlXadZeCdz35COKbVoagb3S+JsRbutrSjVJIqtK3S9RerR54Ni/cyaP+bkIlJMp1YM83YvVFd079x+rFLiqpIeg3T5a6IC2P5nE9lommeakMm6lZ6D16ZPq4ScJFd2WwYZlvjtfztl0khZDZJlqXOJdsCrj+yKcFmUEndtdySBiMzRhxhISLaiYkee8y4xZe3SXT/928oD3Q63RuXulD1pQnXZ+dBd6xmO20ZUqofkw3axH9RlX0I18cO6OsQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Wed, 22 Feb 2023 12:59:22 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 22.02.2023 13:00, Xenia Ragiadakou wrote:
> Remove forward declaration of struct vcpu, that is a leftover since
> the removal of svm_update_guest_cr()'s declaration from svm.h.
>
> Signed-off-by: Xenia Ragiadakou <burzalodowa@xxxxxxxxx>
Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
> Fixes: b158e72abe30 ("x86/hvm: CFI hardening for hvm_funcs")
I'm a little puzzled by this (a stray forward decl of a struct isn't
really a bug imo), but ...
> ---
>
> Changes in v2:
> - leave the forward declaration of struct cpu_user_regs in place,
> suggested by Andrew
> - add a fixes tag based on Andrew's comment
... I realize you were asked to add it. (As a minor remark, more
commonly the Fixes: tag would come ahead of the S-o-b: one, I think.)
Jan
|
